Andy Green e48eb085ac USB: belkin_sa: avoid divide by zero error ... The belkin_sa module has a problem coping with a 0 return from tty_get_baud_rate() -- the subsequent BELKIN_SA_BAUD macro drivers/usb/serial/belkin_sa.h:#define BELKIN_SA_BAUD(b) (230400/b) performs a divide with it leading to the following divide error: usb 3-1: Belkin / Peracom / GoHubs USB Serial Adapter converter now attached to ttyUSB0 PM: Adding info for No Bus:usbdev3.3_ep81 PM: Adding info for No Bus:usbdev3.3_ep01 PM: Adding info for No Bus:usbdev3.3_ep82 divide error: 0000 [#1] SMP Modules linked in: vfat fat iwl3945 mac80211 cfg80211 belkin_sa usbserial usb_storage autofs4 vmnet(P) vmmon(P) aes nf_conntrack_netbios_ns ipt_REJECT nf_conntrack_ipv4 xt_state nf_conntrack nfnetlink xt_tcpudp iptable_filter ip_tables x_tables cpufreq_ondemand acpi_cpufreq video output sbs button dock battery ac arc4 snd_hda_intel ecb blkcipher snd_seq_dummy snd_seq_oss snd_seq_midi_event snd_seq snd_seq_device snd_pcm_oss sr_mod snd_mixer_oss rtc_cmos cdrom iTCO_wdt iTCO_vendor_support snd_pcm rtc_core snd_timer serio_raw b44 ssb rtc_lib parport ata_piix snd soundcore snd_page_alloc mii ata_generic sg ahci libata sd_mod scsi_mod ext3 jbd mbcache ehci_hcd ohci_hcd uhci_hcd CPU: 1 EIP: 0060:[<f8dd1747>] Tainted: P VLI EFLAGS: 00010246 (2.6.23-rc1 #1) EIP is at belkin_sa_set_termios+0x18e/0x5b9 [belkin_sa] eax: 00038400 ebx: 00000000 ecx: 00000000 edx: 00000000 esi: 00038400 edi: 00001cb2 ebp: de49adb0 esp: de49ad6c ds: 007b es: 007b fs: 00d8 gs: 0033 ss: 0068 Process minicom (pid: 7306, ti=de49a000 task=eed6c3b0 task.ti=de49a000) Stack: d85c74f0 00000046 00000002 00000001 d85c74f0 d85c74f0 00000246 c887c658 00000001 00000cb0 00000001 00000084 00000000 d01b58c0 f6ba10e0 de49ade8 de49ae40 de49add0 f8e2526b d85c74b8 ca6e6dbc de49ae40 d85c746c eded72e8 Call Trace: [<c0405f35>] show_trace_log_lvl+0x1a/0x2f [<c0405fe5>] show_stack_log_lvl+0x9b/0xa3 [<c04061a5>] show_registers+0x1b8/0x289 [<c0406389>] die+0x113/0x246 [<c0622f98>] do_trap+0x8a/0xa3 [<c04068dc>] do_divide_error+0x85/0x8f [<c0622d6a>] error_code+0x72/0x78 [<f8e2526b>] serial_set_termios+0x86/0x8d [usbserial] [<c0542d33>] set_termios+0x309/0x34c [<c0542ece>] n_tty_ioctl+0x158/0x4ba [<c054030b>] tty_ioctl+0xc78/0xcd6 [<c048aea0>] do_ioctl+0x50/0x67 [<c048b100>] vfs_ioctl+0x249/0x25c [<c048b15c>] sys_ioctl+0x49/0x61 [<c0404ed2>] sysenter_past_esp+0x5f/0x99 ======================= Code: 85 c0 79 14 c7 44 24 04 67 1c dd f8 c7 04 24 d4 1e dd f8 e8 96 99 65 c7 8b 46 04 be 00 84 03 00 e8 47 11 77 c7 31 d2 89 c1 89 f0 <f7> f1 66 85 c0 89 c1 b8 01 00 00 00 0f 44 c8 8b 45 d8 85 db 8b EIP: [<f8dd1747>] belkin_sa_set_termios+0x18e/0x5b9 [belkin_sa] SS:ESP 0068:de49ad6c The small patch below should take care of this situation. Note that my kernel was tainted (vmware) but the problem will occur if tty_get_baud_rate() ever returns zero and should be taken care of. Signed-off-by: Andy Green <andy@warmcat.com> Cc: William Greathouse <wgreathouse@smva.com> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk> Cc: stable <stable@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>		2007-08-22 14:27:46 -07:00
..
acorn/char	Remove the arm26 port	2007-07-31 15:39:39 -07:00
acpi	ACPI: EC: Fix "no battery" regression	2007-08-14 01:03:42 -04:00
amba
ata	libata: adjust libata to ignore errors after spinup	2007-08-15 04:56:32 -04:00
atm	Add some help texts to recently-introduced kconfig items	2007-08-18 09:52:50 -07:00
auxdisplay	Add some help texts to recently-introduced kconfig items	2007-08-18 09:52:50 -07:00
base	CPU online file permission	2007-07-31 15:39:39 -07:00
block	Add some help texts to recently-introduced kconfig items	2007-08-18 09:52:50 -07:00
bluetooth
cdrom	[BLOCK] Get rid of request_queue_t typedef	2007-07-24 09:28:11 +02:00
char	[WATCHDOG] Add support for 1533 bridge to alim1535_wdt	2007-08-16 20:28:43 +00:00
clocksource	x86_64: fix typo in acpi_pm.c	2007-07-21 18:37:12 -07:00
connector
cpufreq
crypto	Add some help texts to recently-introduced kconfig items	2007-08-18 09:52:50 -07:00
dio
dma	[IOAT]: Remove redundant struct member to avoid descriptor cache miss	2007-08-14 17:36:31 -07:00
edac	drivers/edac: fix pasemi kconfig depends	2007-07-26 11:35:18 -07:00
eisa
fc4
firewire	firewire: fw-core: make two variables static	2007-08-02 20:34:17 +02:00
firmware
hid	Add some help texts to recently-introduced kconfig items	2007-08-18 09:52:50 -07:00
hwmon	hwmon: (smsc47m1) restore missing name attribute	2007-08-12 14:39:44 -04:00
i2c	i2c-s3c2410: Build fix	2007-08-14 18:37:15 +02:00
ide	ide-disk: workaround for buggy HPA support on ST340823A (take 3)	2007-08-20 22:42:57 +02:00
ieee1394	ieee1394: sbp2: more correct Kconfig dependencies	2007-08-02 20:34:16 +02:00
infiniband	IB/mlx4: Incorrect semicolon after if statement	2007-08-15 20:24:06 -07:00
input	[MIPS] Fixup secure computing stuff.	2007-07-31 21:35:21 +01:00
isdn	hisax: update hfc_usb driver	2007-08-21 10:14:28 -07:00
kvm	KVM: Avoid calling smp_call_function_single() with interrupts disabled	2007-08-19 10:13:49 -07:00
leds
lguest	i386: Make patching more robust, fix paravirt issue	2007-08-11 15:58:13 -07:00
macintosh	Add some help texts to recently-introduced kconfig items	2007-08-18 09:52:50 -07:00
mca
md	Fix remap handling by blktrace	2007-08-11 22:34:48 +02:00
media	V4L/DVB (6028): Turn an unnecessary mdelay() into msleep().	2007-08-20 12:18:05 -03:00
message	Merge master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6	2007-08-06 17:48:34 -07:00
mfd
misc	Add some help texts to recently-introduced kconfig items	2007-08-18 09:52:50 -07:00
mmc	mmc: at91_mci: remove whitespace at the end of lines	2007-08-09 16:13:44 +02:00
mtd	mtdchar build fix	2007-08-11 15:47:41 -07:00
net	[PPP]: Fix output buffer size in ppp_decompress_frame().	2007-08-21 20:59:35 -07:00
nubus
of
oprofile
parisc
parport	parport_pc locking fix	2007-07-31 15:39:37 -07:00
pci	pci: rename __pci_reenable_device() to pci_reenable_device()	2007-08-01 10:00:56 -04:00
pcmcia	pcmcia: give socket time to power down	2007-07-31 15:39:38 -07:00
pnp	ACPI: restore CONFIG_ACPI_SLEEP	2007-07-29 16:53:59 -07:00
power	Don't compile the PMU power driver on 64-bit PowerPC	2007-07-23 12:42:45 +01:00
ps3
rapidio
rtc	rtc-m48t59 driver NO_IRQ mode fixup	2007-07-31 15:39:44 -07:00
s390	[S390] vmur: fix reference counting for vmur device structure	2007-08-22 13:51:48 +02:00
sbus	Videopix Frame Grabber: Fix unreleased lock in vfc_debug()	2007-07-31 15:39:43 -07:00
scsi	Merge master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6	2007-08-06 17:48:34 -07:00
serial	serial: fix 8250 early console setup	2007-08-03 15:02:56 -07:00
sh
sn
spi	spidev warning fix	2007-08-11 15:47:42 -07:00
tc
telephony
uio
usb	USB: belkin_sa: avoid divide by zero error	2007-08-22 14:27:46 -07:00
video	Merge master.kernel.org:/home/rmk/linux-2.6-arm	2007-08-18 10:28:21 -07:00
w1	drivers/ misc __iomem annotations	2007-07-26 11:11:57 -07:00
xen	xenbus_xs.c: fix a use-after-free	2007-07-26 11:35:17 -07:00
zorro
Kconfig
Makefile	[WATCHDOG] Fix pcwd_init_module crash	2007-07-29 18:58:39 +00:00