kevin/linux
1
Fork 0
Code
e2ce504977
linux/drivers/staging/cx25821
History
Julia Lawall e2ce504977 drivers/staging/cx25821/cx25821-video.c: introduce missing kfree 
Error handling code following a kmalloc should free the allocated data.

The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@

x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
     when != if (...) { <+...x...+> }
(
x->f1 = E
|
 (x->f1 == NULL || ...)
|
 f(...,x->f1,...)
)
...>
(
 return \(0\|<+...x...+>\|ptr\);
|
 return@p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-20 14:11:47 -07:00
..
cx25821-alsa.c [media] staging/cx25721: serialize access to devlist 2011-03-21 20:32:41 -03:00
cx25821-audio-upstream.c staging: cx25821: Remove NULL check before kfree 2011-03-14 11:57:31 -07:00
cx25821-audio-upstream.h
cx25821-audio.h
cx25821-biffuncs.h
cx25821-cards.c
cx25821-core.c [media] staging/cx25721: serialize access to devlist 2011-03-21 20:32:41 -03:00
cx25821-gpio.c
cx25821-gpio.h
cx25821-i2c.c
cx25821-medusa-defines.h
cx25821-medusa-reg.h
cx25821-medusa-video.c
cx25821-medusa-video.h
cx25821-reg.h
cx25821-sram.h
cx25821-video-upstream-ch2.c staging: cx25821: Remove NULL check before kfree 2011-03-14 11:57:31 -07:00
cx25821-video-upstream-ch2.h
cx25821-video-upstream.c staging: cx25821: Remove NULL check before kfree 2011-03-14 11:57:31 -07:00
cx25821-video-upstream.h
cx25821-video.c drivers/staging/cx25821/cx25821-video.c: introduce missing kfree 2011-04-20 14:11:47 -07:00
cx25821-video.h
cx25821.h [media] staging/cx25721: serialize access to devlist 2011-03-21 20:32:41 -03:00
Kconfig [media] staging/cx25721: serialize access to devlist 2011-03-21 20:32:41 -03:00
Makefile
README

README 

Todo:
	- checkpatch.pl cleanups
	- sparse cleanups

Please send patches to linux-media@vger.kernel.org