56f45266df
This timer HW supports 8, 16 and 32-bit timer widths. This driver currently uses a u32 to store the max possible value of the timer. However, statements perform addition of 2 in xilinx_pwm_apply() when calculating the period_cycles and duty_cycles values. Since priv->max is a u32, this will result in an overflow to 1 which will not only be incorrect but fail on range comparison. This results in making it impossible to set the PWM in this timer mode. There are two obvious solutions to the current problem: 1. Cast each instance where overflow occurs to u64. 2. Change priv->max from a u32 to a u64. Solution #1 requires more code modifications, and leaves opportunity to introduce similar overflows if other math statements are added in the future. These may also go undetected if running in non 32-bit timer modes. Solution #2 is the much smaller and cleaner approach and thus the chosen method in this patch. This was tested on a Zynq UltraScale+ with multiple instances of the PWM IP. Signed-off-by: Ken Sloat <ksloat@designlinxhs.com> Reviewed-by: Michal Simek <michal.simek@amd.com> Reviewed-by: Sean Anderson <sean.anderson@seco.com> Link: https://lore.kernel.org/r/SJ0P222MB0107490C5371B848EF04351CA1E19@SJ0P222MB0107.NAMP222.PROD.OUTLOOK.COM Signed-off-by: Michal Simek <michal.simek@amd.com>
74 lines
1.7 KiB
C
74 lines
1.7 KiB
C
/* SPDX-License-Identifier: GPL-2.0+ */
|
|
/*
|
|
* Copyright (C) 2021 Sean Anderson <sean.anderson@seco.com>
|
|
*/
|
|
|
|
#ifndef XILINX_TIMER_H
|
|
#define XILINX_TIMER_H
|
|
|
|
#include <linux/compiler.h>
|
|
|
|
#define TCSR0 0x00
|
|
#define TLR0 0x04
|
|
#define TCR0 0x08
|
|
#define TCSR1 0x10
|
|
#define TLR1 0x14
|
|
#define TCR1 0x18
|
|
|
|
#define TCSR_MDT BIT(0)
|
|
#define TCSR_UDT BIT(1)
|
|
#define TCSR_GENT BIT(2)
|
|
#define TCSR_CAPT BIT(3)
|
|
#define TCSR_ARHT BIT(4)
|
|
#define TCSR_LOAD BIT(5)
|
|
#define TCSR_ENIT BIT(6)
|
|
#define TCSR_ENT BIT(7)
|
|
#define TCSR_TINT BIT(8)
|
|
#define TCSR_PWMA BIT(9)
|
|
#define TCSR_ENALL BIT(10)
|
|
#define TCSR_CASC BIT(11)
|
|
|
|
struct clk;
|
|
struct device_node;
|
|
struct regmap;
|
|
|
|
/**
|
|
* struct xilinx_timer_priv - Private data for Xilinx AXI timer drivers
|
|
* @map: Regmap of the device, possibly with an offset
|
|
* @clk: Parent clock
|
|
* @max: Maximum value of the counters
|
|
*/
|
|
struct xilinx_timer_priv {
|
|
struct regmap *map;
|
|
struct clk *clk;
|
|
u64 max;
|
|
};
|
|
|
|
/**
|
|
* xilinx_timer_tlr_cycles() - Calculate the TLR for a period specified
|
|
* in clock cycles
|
|
* @priv: The timer's private data
|
|
* @tcsr: The value of the TCSR register for this counter
|
|
* @cycles: The number of cycles in this period
|
|
*
|
|
* Callers of this function MUST ensure that @cycles is representable as
|
|
* a TLR.
|
|
*
|
|
* Return: The calculated value for TLR
|
|
*/
|
|
u32 xilinx_timer_tlr_cycles(struct xilinx_timer_priv *priv, u32 tcsr,
|
|
u64 cycles);
|
|
|
|
/**
|
|
* xilinx_timer_get_period() - Get the current period of a counter
|
|
* @priv: The timer's private data
|
|
* @tlr: The value of TLR for this counter
|
|
* @tcsr: The value of TCSR for this counter
|
|
*
|
|
* Return: The period, in ns
|
|
*/
|
|
unsigned int xilinx_timer_get_period(struct xilinx_timer_priv *priv,
|
|
u32 tlr, u32 tcsr);
|
|
|
|
#endif /* XILINX_TIMER_H */
|