1
linux/drivers/media/pci
Steven Rostedt (Google) 292a089d78 treewide: Convert del_timer*() to timer_shutdown*()
Due to several bugs caused by timers being re-armed after they are
shutdown and just before they are freed, a new state of timers was added
called "shutdown".  After a timer is set to this state, then it can no
longer be re-armed.

The following script was run to find all the trivial locations where
del_timer() or del_timer_sync() is called in the same function that the
object holding the timer is freed.  It also ignores any locations where
the timer->function is modified between the del_timer*() and the free(),
as that is not considered a "trivial" case.

This was created by using a coccinelle script and the following
commands:

    $ cat timer.cocci
    @@
    expression ptr, slab;
    identifier timer, rfield;
    @@
    (
    -       del_timer(&ptr->timer);
    +       timer_shutdown(&ptr->timer);
    |
    -       del_timer_sync(&ptr->timer);
    +       timer_shutdown_sync(&ptr->timer);
    )
      ... when strict
          when != ptr->timer
    (
            kfree_rcu(ptr, rfield);
    |
            kmem_cache_free(slab, ptr);
    |
            kfree(ptr);
    )

    $ spatch timer.cocci . > /tmp/t.patch
    $ patch -p1 < /tmp/t.patch

Link: https://lore.kernel.org/lkml/20221123201306.823305113@linutronix.de/
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Acked-by: Pavel Machek <pavel@ucw.cz> [ LED ]
Acked-by: Kalle Valo <kvalo@kernel.org> [ wireless ]
Acked-by: Paolo Abeni <pabeni@redhat.com> [ networking ]
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2022-12-25 13:38:09 -08:00
..
b2c2
bt8xx bttv: remove unused tea5757_set_freq declaration 2022-10-24 19:03:52 +02:00
cobalt
cx18 media: pci/cx18: fix repeated words in comments 2022-09-24 08:47:29 +02:00
cx88 media: cx88: add IR remote support for NotOnlyTV LV3H 2022-09-24 11:21:43 +02:00
cx23885 media: cx23885: reset DMA on AMD Renior/Cezanne IOMMU due to RiSC engine stall 2022-08-30 07:35:21 +02:00
cx25821 cx25821: remove unused cx25821_video_wakeup() declaration 2022-10-24 19:03:52 +02:00
ddbridge driver core: make struct class.devnode() take a const * 2022-11-24 17:12:27 +01:00
dm1105
dt3155
intel media: ipu3-cio2: make the bridge depend on i2c 2022-12-07 17:58:41 +01:00
ivtv treewide: Convert del_timer*() to timer_shutdown*() 2022-12-25 13:38:09 -08:00
mantis media: mantis: Kconfig: add depends on DVB_CORE for MANTIS_CORE 2022-11-25 10:04:11 +00:00
netup_unidvb
ngene media: media/pci/ngene/ngene.h: remove #ifdef NGENE_V4L 2022-08-29 15:37:30 +02:00
pluto2
pt1
pt3 media: pt3: Use dma_set_mask_and_coherent() and simplify code 2022-12-07 17:58:46 +01:00
saa7134 media: saa7134: remove unused declarations in saa7134.h 2022-10-24 19:03:52 +02:00
saa7164 media: saa7164: fix missing pci_disable_device() 2022-12-06 07:13:04 +00:00
smipcie
solo6x10 media: solo6x10: fix possible memory leak in solo_sysfs_init() 2022-11-25 07:36:22 +00:00
sta2x11
tw68
tw686x
tw5864
zoran media: zoran: remove unused declarations in zoran_device.h 2022-10-24 19:03:52 +02:00
Kconfig media: saa7146: deprecate hexium_gemini/orion, mxb and ttpci 2022-08-29 16:46:38 +02:00
Makefile media: saa7146: deprecate hexium_gemini/orion, mxb and ttpci 2022-08-29 16:46:38 +02:00