kevin/linux
1
Fork 0
Code
d8672b40d3
linux/net/rose
History
Bernard Pidoux 244f46ae6e rose: zero length frame filtering in af_rose.c 
Since changeset e79ad711a0 from  mainline,
>From David S. Miller,
empty packet can be transmitted on connected socket for datagram protocols.

However, this patch broke a high level application using ROSE network protocol with connected datagram.

Bulletin Board Stations perform bulletins forwarding between BBS stations via ROSE network using a forward protocol.
Now, if for some reason, a buffer in the application software happens to be empty at a specific moment,
ROSE sends an empty packet via unfiltered packet socket.
When received, this ROSE packet introduces perturbations of data exchange of BBS forwarding,
for the application message forwarding protocol is waiting for something else.
We agree that a more careful programming of the application protocol would avoid this situation and we are
willing to debug it.
But, as an empty frame is no use and does not have any meaning for ROSE protocol,
we may consider filtering zero length data both when sending and receiving socket data.

The proposed patch repaired BBS data exchange through ROSE network that were broken since 2.6.22.11 kernel.

Signed-off-by: Bernard Pidoux <f6bvp@amsat.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-11-25 00:56:20 -08:00
..
af_rose.c rose: zero length frame filtering in af_rose.c 2008-11-25 00:56:20 -08:00
Makefile Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
rose_dev.c [ROSE]: Trivial compilation CONFIG_INET=n case 2007-12-05 05:37:28 -08:00
rose_in.c [ROSE]: Supress sparse warnings 2008-01-28 15:02:44 -08:00
rose_link.c [ROSE]: Eleminate HZ from ROSE kernel interfaces 2006-05-03 23:28:20 -07:00
rose_loopback.c [ROSE]: Fix rose.ko oops on unload 2007-10-07 23:44:17 -07:00
rose_out.c [PATCH] remove many unneeded #includes of sched.h 2007-02-14 08:09:54 -08:00
rose_route.c rose: improving AX25 routing frames via ROSE network 2008-06-17 17:08:32 -07:00
rose_subr.c [PATCH] remove many unneeded #includes of sched.h 2007-02-14 08:09:54 -08:00
rose_timer.c [ROSE]: rose_heartbeat_expiry() locking fix 2005-10-31 16:41:45 -02:00
sysctl_net_rose.c [NET]: Simple ctl_table to ctl_path conversions. 2008-01-28 15:01:07 -08:00