1
linux/sound/soc/s3c24xx
Jean Delvare d280289e79 sound: ASoC: Fix an error path in neo1973_wm8753
The error handling in neo1973_init is incorrect:

* If platform_device_add fails, we go on with the rest of the
  initialization instead of bailing out. Things will break when the
  module is removed (platform_device_unregister called on a device
  that wasn't registered.)

* If i2c_add_driver fails, we return an error so the module will not
  load, but we don't unregister neo1973_snd_device, so we are leaking
  resources.

Add the missing error handling.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Tim Niemeyer <reddog@mastersword.de>
Cc: Graeme Gregory <graeme@openmoko.org>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
2008-09-09 09:11:07 +02:00
..
Kconfig sound: Convert to menuconfig 2008-05-27 15:56:20 +02:00
lm4857.h [ALSA] ASoC S3C24xx machine drivers - lm4857-h missing patch 2007-07-20 11:11:29 +02:00
ln2440sbc_alc650.c [ALSA] soc - ln2440sbc_alc650 - Fix checkpatch warnings 2008-04-30 19:38:06 +02:00
Makefile [ALSA] ASoC: S3C2412 IIS driver 2008-01-31 17:29:53 +01:00
neo1973_wm8753.c sound: ASoC: Fix an error path in neo1973_wm8753 2008-09-09 09:11:07 +02:00
s3c24xx-ac97.h ALSA: asoc: s3c24xx - merge structs snd_soc_codec_dai and snd_soc_cpu_dai. 2008-07-10 09:32:45 +02:00
s3c24xx-i2s.c [ARM] Move include/asm-arm/arch-* to arch/arm/*/include/mach 2008-08-07 09:55:48 +01:00
s3c24xx-i2s.h ALSA: asoc: s3c24xx - merge structs snd_soc_codec_dai and snd_soc_cpu_dai. 2008-07-10 09:32:45 +02:00
s3c24xx-pcm.c [ARM] Move include/asm-arm/arch-* to arch/arm/*/include/mach 2008-08-07 09:55:48 +01:00
s3c24xx-pcm.h [ALSA] ASoC Samsung S3c24xx updates - audio DMA cleanup 2007-05-11 16:56:03 +02:00
s3c2412-i2s.c [ARM] Move include/asm-arm/arch-* to arch/arm/*/include/mach 2008-08-07 09:55:48 +01:00
s3c2412-i2s.h ALSA: asoc: s3c24xx - merge structs snd_soc_codec_dai and snd_soc_cpu_dai. 2008-07-10 09:32:45 +02:00
s3c2443-ac97.c [ARM] Move include/asm-arm/arch-* to arch/arm/*/include/mach 2008-08-07 09:55:48 +01:00
smdk2443_wm9710.c [ALSA] ASoC: Remove in-code changelogs 2008-05-19 13:19:20 +02:00