173f6cd384
Commitff82e84e80("coccinelle: device_attr_show: simplify patch case") simplifies the patch case, as a result, STR is no longer needed. This also helps to fix below coccicheck warning: > warning: rp: metavariable STR not used in the - or context code CC: Julia Lawall <Julia.Lawall@inria.fr> CC: Nicolas Palix <nicolas.palix@imag.fr> CC: cocci@inria.fr Fixes:ff82e84e80("coccinelle: device_attr_show: simplify patch case") Signed-off-by: Li Zhijian <lizhijian@fujitsu.com> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
55 lines
1.1 KiB
Plaintext
55 lines
1.1 KiB
Plaintext
// SPDX-License-Identifier: GPL-2.0-only
|
|
///
|
|
/// From Documentation/filesystems/sysfs.rst:
|
|
/// show() should only use sysfs_emit() or sysfs_emit_at() when formatting
|
|
/// the value to be returned to user space.
|
|
///
|
|
// Confidence: High
|
|
// Copyright: (C) 2020 Denis Efremov ISPRAS
|
|
// Options: --no-includes --include-headers
|
|
//
|
|
|
|
virtual report
|
|
virtual org
|
|
virtual context
|
|
virtual patch
|
|
|
|
@r depends on !patch@
|
|
identifier show, dev, attr, buf;
|
|
position p;
|
|
@@
|
|
|
|
ssize_t show(struct device *dev, struct device_attribute *attr, char *buf)
|
|
{
|
|
<...
|
|
* return snprintf@p(...);
|
|
...>
|
|
}
|
|
|
|
@rp depends on patch@
|
|
identifier show, dev, attr, buf;
|
|
expression BUF, SZ, FORMAT;
|
|
@@
|
|
|
|
ssize_t show(struct device *dev, struct device_attribute *attr, char *buf)
|
|
{
|
|
<...
|
|
return
|
|
- snprintf(BUF, SZ, FORMAT
|
|
+ sysfs_emit(BUF, FORMAT
|
|
,...);
|
|
...>
|
|
}
|
|
|
|
@script: python depends on report@
|
|
p << r.p;
|
|
@@
|
|
|
|
coccilib.report.print_report(p[0], "WARNING: please use sysfs_emit or sysfs_emit_at")
|
|
|
|
@script: python depends on org@
|
|
p << r.p;
|
|
@@
|
|
|
|
coccilib.org.print_todo(p[0], "WARNING: please use sysfs_emit or sysfs_emit_at")
|