fe73965d07
By allowing the drivers to return a "const *" they can constify their static report arrays. This makes it clear to driver authors that the HID core will not modify those reports and they can be reused for multiple devices. Furthermore security is slightly improved as those reports are protected against accidental or malicious modifications. [bentiss: fixup hid-cougar.c and hid-multitouch.c for latest version of the master branch] Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> Link: https://patch.msgid.link/20240803-hid-const-fixup-v2-6-f53d7a7b29d8@weissschuh.net Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
107 lines
2.6 KiB
C
107 lines
2.6 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* HID driver for some petalynx "special" devices
|
|
*
|
|
* Copyright (c) 1999 Andreas Gal
|
|
* Copyright (c) 2000-2005 Vojtech Pavlik <vojtech@suse.cz>
|
|
* Copyright (c) 2005 Michael Haboustak <mike-@cinci.rr.com> for Concept2, Inc
|
|
* Copyright (c) 2006-2007 Jiri Kosina
|
|
* Copyright (c) 2008 Jiri Slaby
|
|
*/
|
|
|
|
/*
|
|
*/
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/hid.h>
|
|
#include <linux/module.h>
|
|
|
|
#include "hid-ids.h"
|
|
|
|
/* Petalynx Maxter Remote has maximum for consumer page set too low */
|
|
static const __u8 *pl_report_fixup(struct hid_device *hdev, __u8 *rdesc,
|
|
unsigned int *rsize)
|
|
{
|
|
if (*rsize >= 62 && rdesc[39] == 0x2a && rdesc[40] == 0xf5 &&
|
|
rdesc[41] == 0x00 && rdesc[59] == 0x26 &&
|
|
rdesc[60] == 0xf9 && rdesc[61] == 0x00) {
|
|
hid_info(hdev, "fixing up Petalynx Maxter Remote report descriptor\n");
|
|
rdesc[60] = 0xfa;
|
|
rdesc[40] = 0xfa;
|
|
}
|
|
return rdesc;
|
|
}
|
|
|
|
#define pl_map_key_clear(c) hid_map_usage_clear(hi, usage, bit, max, \
|
|
EV_KEY, (c))
|
|
static int pl_input_mapping(struct hid_device *hdev, struct hid_input *hi,
|
|
struct hid_field *field, struct hid_usage *usage,
|
|
unsigned long **bit, int *max)
|
|
{
|
|
if ((usage->hid & HID_USAGE_PAGE) == HID_UP_LOGIVENDOR) {
|
|
switch (usage->hid & HID_USAGE) {
|
|
case 0x05a: pl_map_key_clear(KEY_TEXT); break;
|
|
case 0x05b: pl_map_key_clear(KEY_RED); break;
|
|
case 0x05c: pl_map_key_clear(KEY_GREEN); break;
|
|
case 0x05d: pl_map_key_clear(KEY_YELLOW); break;
|
|
case 0x05e: pl_map_key_clear(KEY_BLUE); break;
|
|
default:
|
|
return 0;
|
|
}
|
|
return 1;
|
|
}
|
|
|
|
if ((usage->hid & HID_USAGE_PAGE) == HID_UP_CONSUMER) {
|
|
switch (usage->hid & HID_USAGE) {
|
|
case 0x0f6: pl_map_key_clear(KEY_NEXT); break;
|
|
case 0x0fa: pl_map_key_clear(KEY_BACK); break;
|
|
default:
|
|
return 0;
|
|
}
|
|
return 1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int pl_probe(struct hid_device *hdev, const struct hid_device_id *id)
|
|
{
|
|
int ret;
|
|
|
|
hdev->quirks |= HID_QUIRK_NOGET;
|
|
|
|
ret = hid_parse(hdev);
|
|
if (ret) {
|
|
hid_err(hdev, "parse failed\n");
|
|
goto err_free;
|
|
}
|
|
|
|
ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT);
|
|
if (ret) {
|
|
hid_err(hdev, "hw start failed\n");
|
|
goto err_free;
|
|
}
|
|
|
|
return 0;
|
|
err_free:
|
|
return ret;
|
|
}
|
|
|
|
static const struct hid_device_id pl_devices[] = {
|
|
{ HID_USB_DEVICE(USB_VENDOR_ID_PETALYNX, USB_DEVICE_ID_PETALYNX_MAXTER_REMOTE) },
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(hid, pl_devices);
|
|
|
|
static struct hid_driver pl_driver = {
|
|
.name = "petalynx",
|
|
.id_table = pl_devices,
|
|
.report_fixup = pl_report_fixup,
|
|
.input_mapping = pl_input_mapping,
|
|
.probe = pl_probe,
|
|
};
|
|
module_hid_driver(pl_driver);
|
|
|
|
MODULE_DESCRIPTION("HID driver for some petalynx \"special\" devices");
|
|
MODULE_LICENSE("GPL");
|