0d60d8df6f
This fixes a possible UAF in if_nlmsg_size(),
which can run without RTNL.
Add rcu protection to "struct dpll_pin"
Move netdev_dpll_pin() from netdevice.h to dpll.h to
decrease name pollution.
Note: This looks possible to no longer acquire RTNL in
netdev_dpll_pin_assign() later in net-next.
v2: do not force rcu_read_lock() in rtnl_dpll_pin_size() (Jiri Pirko)
Fixes: 5f18426928 ("netdev: expose DPLL pin handle for netdevice")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Cc: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Link: https://lore.kernel.org/r/20240223123208.3543319-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
92 lines
2.6 KiB
C
92 lines
2.6 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* Copyright (c) 2023 Meta Platforms, Inc. and affiliates
|
|
* Copyright (c) 2023 Intel and affiliates
|
|
*/
|
|
|
|
#ifndef __DPLL_CORE_H__
|
|
#define __DPLL_CORE_H__
|
|
|
|
#include <linux/dpll.h>
|
|
#include <linux/list.h>
|
|
#include <linux/refcount.h>
|
|
#include "dpll_nl.h"
|
|
|
|
#define DPLL_REGISTERED XA_MARK_1
|
|
|
|
/**
|
|
* struct dpll_device - stores DPLL device internal data
|
|
* @id: unique id number for device given by dpll subsystem
|
|
* @device_idx: id given by dev driver
|
|
* @clock_id: unique identifier (clock_id) of a dpll
|
|
* @module: module of creator
|
|
* @type: type of a dpll
|
|
* @pin_refs: stores pins registered within a dpll
|
|
* @refcount: refcount
|
|
* @registration_list: list of registered ops and priv data of dpll owners
|
|
**/
|
|
struct dpll_device {
|
|
u32 id;
|
|
u32 device_idx;
|
|
u64 clock_id;
|
|
struct module *module;
|
|
enum dpll_type type;
|
|
struct xarray pin_refs;
|
|
refcount_t refcount;
|
|
struct list_head registration_list;
|
|
};
|
|
|
|
/**
|
|
* struct dpll_pin - structure for a dpll pin
|
|
* @id: unique id number for pin given by dpll subsystem
|
|
* @pin_idx: index of a pin given by dev driver
|
|
* @clock_id: clock_id of creator
|
|
* @module: module of creator
|
|
* @dpll_refs: hold referencees to dplls pin was registered with
|
|
* @parent_refs: hold references to parent pins pin was registered with
|
|
* @prop: pin properties copied from the registerer
|
|
* @rclk_dev_name: holds name of device when pin can recover clock from it
|
|
* @refcount: refcount
|
|
* @rcu: rcu_head for kfree_rcu()
|
|
**/
|
|
struct dpll_pin {
|
|
u32 id;
|
|
u32 pin_idx;
|
|
u64 clock_id;
|
|
struct module *module;
|
|
struct xarray dpll_refs;
|
|
struct xarray parent_refs;
|
|
struct dpll_pin_properties prop;
|
|
refcount_t refcount;
|
|
struct rcu_head rcu;
|
|
};
|
|
|
|
/**
|
|
* struct dpll_pin_ref - structure for referencing either dpll or pins
|
|
* @dpll: pointer to a dpll
|
|
* @pin: pointer to a pin
|
|
* @registration_list: list of ops and priv data registered with the ref
|
|
* @refcount: refcount
|
|
**/
|
|
struct dpll_pin_ref {
|
|
union {
|
|
struct dpll_device *dpll;
|
|
struct dpll_pin *pin;
|
|
};
|
|
struct list_head registration_list;
|
|
refcount_t refcount;
|
|
};
|
|
|
|
void *dpll_priv(struct dpll_device *dpll);
|
|
void *dpll_pin_on_dpll_priv(struct dpll_device *dpll, struct dpll_pin *pin);
|
|
void *dpll_pin_on_pin_priv(struct dpll_pin *parent, struct dpll_pin *pin);
|
|
|
|
const struct dpll_device_ops *dpll_device_ops(struct dpll_device *dpll);
|
|
struct dpll_device *dpll_device_get_by_id(int id);
|
|
const struct dpll_pin_ops *dpll_pin_ops(struct dpll_pin_ref *ref);
|
|
struct dpll_pin_ref *dpll_xa_ref_dpll_first(struct xarray *xa_refs);
|
|
extern struct xarray dpll_device_xa;
|
|
extern struct xarray dpll_pin_xa;
|
|
extern struct mutex dpll_lock;
|
|
#endif
|