1
linux/net/sunrpc
Wolfgang Walter 9db619e665 rpc: fix garbage in printk in svc_tcp_accept()
we upgraded the kernel of a nfs-server from 2.6.17.11 to 2.6.22.6. Since
then we get the message

lockd: too many open TCP sockets, consider increasing the number of nfsd threads
lockd: last TCP connect from ^\\236^\É^D

These random characters in the second line are caused by a bug in
svc_tcp_accept.

(Note: there are two previous __svc_print_addr(sin, buf, sizeof(buf))
calls in this function, either of which would initialize buf correctly;
but both are inside "if"'s and are not necessarily executed.  This is
less obvious in the second case, which is inside a dprintk(), which is a
macro which expands to an if statement.)

Signed-off-by: Wolfgang Walter <wolfgang.walter@studentenwerk.mhn.de>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-09-20 13:15:57 -07:00
..
auth_gss [SUNRPC]: Clean up duplicate includes in net/sunrpc/ 2007-08-13 22:52:05 -07:00
auth_null.c SUNRPC: cleanup rpc credential cache garbage collection 2007-07-10 23:40:35 -04:00
auth_unix.c SUNRPC: Remove the tk_auth macro... 2007-07-10 23:40:37 -04:00
auth.c SUNRPC: move bkl locking and xdr proc invocation into a common helper 2007-07-19 15:21:39 -04:00
cache.c SUNRPC: Replace flush_workqueue() with cancel_work_sync() and friends 2007-08-07 16:13:01 -04:00
clnt.c sunrpc: drop BKL around wrap and unwrap 2007-07-10 23:40:50 -04:00
Makefile
rpc_pipe.c SUNRPC: Replace flush_workqueue() with cancel_work_sync() and friends 2007-08-07 16:13:01 -04:00
rpcb_clnt.c SUNRPC: Rename rpcb_getport to be consistent with new rpcb_getport_sync name 2007-07-10 23:40:46 -04:00
sched.c SUNRPC: Fix a race in rpciod_down() 2007-08-07 15:13:16 -04:00
socklib.c
stats.c
sunrpc_syms.c SUNRPC: Convert the credential garbage collector into a shrinker callback 2007-07-10 23:40:36 -04:00
svc.c
svcauth_unix.c knfsd: nfsd: set rq_client to ip-address-determined-domain 2007-07-17 10:23:07 -07:00
svcauth.c
svcsock.c rpc: fix garbage in printk in svc_tcp_accept() 2007-09-20 13:15:57 -07:00
sysctl.c
timer.c
xdr.c
xprt.c SUNRPC: cleanup transport creation argument passing 2007-07-10 23:40:49 -04:00
xprtsock.c SUNRPC client: add interface for binding to a local address 2007-07-10 23:40:49 -04:00