825d8bbd2f
Commit4f563a6473("block: add a max_user_discard_sectors queue limit") changed block core to set max_discard_sectors to: min(lim->max_hw_discard_sectors, lim->max_user_discard_sectors) Since commit1c0e720228("dm: use queue_limits_set") it was reported dm-thinp was failing in a few fstests (generic/347 and generic/405) with the first WARN_ON_ONCE in dm_cell_key_has_valid_range() being reported, e.g.: WARNING: CPU: 1 PID: 30 at drivers/md/dm-bio-prison-v1.c:128 dm_cell_key_has_valid_range+0x3d/0x50 blk_set_stacking_limits() sets max_user_discard_sectors to UINT_MAX, so given how block core now sets max_discard_sectors (detailed above) it follows that blk_stack_limits() stacks up the underlying device's max_hw_discard_sectors and max_discard_sectors is set to match it. If max_hw_discard_sectors exceeds dm's BIO_PRISON_MAX_RANGE, then dm_cell_key_has_valid_range() will trigger the warning with: WARN_ON_ONCE(key->block_end - key->block_begin > BIO_PRISON_MAX_RANGE) Aside from this warning, the discard will fail. Fix this and other DM issues by governing discard support in terms of max_hw_discard_sectors instead of max_discard_sectors. Reported-by: Theodore Ts'o <tytso@mit.edu> Fixes:1c0e720228("dm: use queue_limits_set") Signed-off-by: Mike Snitzer <snitzer@kernel.org>
82 lines
1.6 KiB
C
82 lines
1.6 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (C) 2003 Jana Saout <jana@saout.de>
|
|
*
|
|
* This file is released under the GPL.
|
|
*/
|
|
|
|
#include <linux/device-mapper.h>
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/init.h>
|
|
#include <linux/bio.h>
|
|
|
|
#define DM_MSG_PREFIX "zero"
|
|
|
|
/*
|
|
* Construct a dummy mapping that only returns zeros
|
|
*/
|
|
static int zero_ctr(struct dm_target *ti, unsigned int argc, char **argv)
|
|
{
|
|
if (argc != 0) {
|
|
ti->error = "No arguments required";
|
|
return -EINVAL;
|
|
}
|
|
|
|
/*
|
|
* Silently drop discards, avoiding -EOPNOTSUPP.
|
|
*/
|
|
ti->num_discard_bios = 1;
|
|
ti->discards_supported = true;
|
|
|
|
return 0;
|
|
}
|
|
|
|
/*
|
|
* Return zeros only on reads
|
|
*/
|
|
static int zero_map(struct dm_target *ti, struct bio *bio)
|
|
{
|
|
switch (bio_op(bio)) {
|
|
case REQ_OP_READ:
|
|
if (bio->bi_opf & REQ_RAHEAD) {
|
|
/* readahead of null bytes only wastes buffer cache */
|
|
return DM_MAPIO_KILL;
|
|
}
|
|
zero_fill_bio(bio);
|
|
break;
|
|
case REQ_OP_WRITE:
|
|
case REQ_OP_DISCARD:
|
|
/* writes get silently dropped */
|
|
break;
|
|
default:
|
|
return DM_MAPIO_KILL;
|
|
}
|
|
|
|
bio_endio(bio);
|
|
|
|
/* accepted bio, don't make new request */
|
|
return DM_MAPIO_SUBMITTED;
|
|
}
|
|
|
|
static void zero_io_hints(struct dm_target *ti, struct queue_limits *limits)
|
|
{
|
|
limits->max_hw_discard_sectors = UINT_MAX;
|
|
limits->discard_granularity = 512;
|
|
}
|
|
|
|
static struct target_type zero_target = {
|
|
.name = "zero",
|
|
.version = {1, 2, 0},
|
|
.features = DM_TARGET_NOWAIT,
|
|
.module = THIS_MODULE,
|
|
.ctr = zero_ctr,
|
|
.map = zero_map,
|
|
.io_hints = zero_io_hints,
|
|
};
|
|
module_dm(zero);
|
|
|
|
MODULE_AUTHOR("Jana Saout <jana@saout.de>");
|
|
MODULE_DESCRIPTION(DM_NAME " dummy target returning zeros");
|
|
MODULE_LICENSE("GPL");
|