9f4441fcbb
There is no need for a driver to individually add/create device groups, the driver core will do it automatically for you. Convert the hid-vivaldi core driver to use the dev_groups pointer instead of manually calling the driver core to create the group and have it be cleaned up later on by the devm core. Cc: Jiri Kosina <jikos@kernel.org> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> Cc: linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
58 lines
1.2 KiB
C
58 lines
1.2 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* HID support for Vivaldi Keyboard
|
|
*
|
|
* Copyright 2020 Google LLC.
|
|
* Author: Sean O'Brien <seobrien@chromium.org>
|
|
*/
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/hid.h>
|
|
#include <linux/input/vivaldi-fmap.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
|
|
#include "hid-vivaldi-common.h"
|
|
|
|
static int vivaldi_probe(struct hid_device *hdev,
|
|
const struct hid_device_id *id)
|
|
{
|
|
struct vivaldi_data *drvdata;
|
|
int ret;
|
|
|
|
drvdata = devm_kzalloc(&hdev->dev, sizeof(*drvdata), GFP_KERNEL);
|
|
if (!drvdata)
|
|
return -ENOMEM;
|
|
|
|
hid_set_drvdata(hdev, drvdata);
|
|
|
|
ret = hid_parse(hdev);
|
|
if (ret)
|
|
return ret;
|
|
|
|
return hid_hw_start(hdev, HID_CONNECT_DEFAULT);
|
|
}
|
|
|
|
static const struct hid_device_id vivaldi_table[] = {
|
|
{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_VIVALDI, HID_ANY_ID, HID_ANY_ID) },
|
|
{ }
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(hid, vivaldi_table);
|
|
|
|
static struct hid_driver hid_vivaldi = {
|
|
.name = "hid-vivaldi",
|
|
.id_table = vivaldi_table,
|
|
.probe = vivaldi_probe,
|
|
.feature_mapping = vivaldi_feature_mapping,
|
|
.driver = {
|
|
.dev_groups = vivaldi_attribute_groups,
|
|
},
|
|
};
|
|
|
|
module_hid_driver(hid_vivaldi);
|
|
|
|
MODULE_AUTHOR("Sean O'Brien");
|
|
MODULE_DESCRIPTION("HID vivaldi driver");
|
|
MODULE_LICENSE("GPL");
|