fe73965d07
By allowing the drivers to return a "const *" they can constify their static report arrays. This makes it clear to driver authors that the HID core will not modify those reports and they can be reused for multiple devices. Furthermore security is slightly improved as those reports are protected against accidental or malicious modifications. [bentiss: fixup hid-cougar.c and hid-multitouch.c for latest version of the master branch] Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> Link: https://patch.msgid.link/20240803-hid-const-fixup-v2-6-f53d7a7b29d8@weissschuh.net Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
56 lines
1.7 KiB
C
56 lines
1.7 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* HID driver for various devices which are apparently based on the same chipset
|
|
* from certain vendor which produces chips that contain wrong LogicalMaximum
|
|
* value in their HID report descriptor. Currently supported devices are:
|
|
*
|
|
* Ortek PKB-1700
|
|
* Ortek WKB-2000
|
|
* iHome IMAC-A210S
|
|
* Skycable wireless presenter
|
|
*
|
|
* Copyright (c) 2010 Johnathon Harris <jmharris@gmail.com>
|
|
* Copyright (c) 2011 Jiri Kosina
|
|
*/
|
|
|
|
/*
|
|
*/
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/hid.h>
|
|
#include <linux/module.h>
|
|
|
|
#include "hid-ids.h"
|
|
|
|
static const __u8 *ortek_report_fixup(struct hid_device *hdev, __u8 *rdesc,
|
|
unsigned int *rsize)
|
|
{
|
|
if (*rsize >= 56 && rdesc[54] == 0x25 && rdesc[55] == 0x01) {
|
|
hid_info(hdev, "Fixing up logical maximum in report descriptor (Ortek)\n");
|
|
rdesc[55] = 0x92;
|
|
} else if (*rsize >= 54 && rdesc[52] == 0x25 && rdesc[53] == 0x01) {
|
|
hid_info(hdev, "Fixing up logical maximum in report descriptor (Skycable)\n");
|
|
rdesc[53] = 0x65;
|
|
}
|
|
return rdesc;
|
|
}
|
|
|
|
static const struct hid_device_id ortek_devices[] = {
|
|
{ HID_USB_DEVICE(USB_VENDOR_ID_ORTEK, USB_DEVICE_ID_ORTEK_PKB1700) },
|
|
{ HID_USB_DEVICE(USB_VENDOR_ID_ORTEK, USB_DEVICE_ID_ORTEK_WKB2000) },
|
|
{ HID_USB_DEVICE(USB_VENDOR_ID_ORTEK, USB_DEVICE_ID_ORTEK_IHOME_IMAC_A210S) },
|
|
{ HID_USB_DEVICE(USB_VENDOR_ID_SKYCABLE, USB_DEVICE_ID_SKYCABLE_WIRELESS_PRESENTER) },
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(hid, ortek_devices);
|
|
|
|
static struct hid_driver ortek_driver = {
|
|
.name = "ortek",
|
|
.id_table = ortek_devices,
|
|
.report_fixup = ortek_report_fixup
|
|
};
|
|
module_hid_driver(ortek_driver);
|
|
|
|
MODULE_DESCRIPTION("HID driver for Ortek PKB-1700/WKB-2000/Skycable wireless keyboard and mouse trackpad");
|
|
MODULE_LICENSE("GPL");
|