1
linux/arch/arm/plat-samsung
Vasily Khoruzhick 812c4e40c2 ARM: S3C24XX: Fix mess with gpio {set,get}_pull callbacks
Currently the {set,get}_pull callbacks of the s3c24xx_gpiocfg_default structure
are initalized via s3c_gpio_{get,set}pull_1up. This results in a linker
error when only CONFIG_CPU_S3C2442 is selected:

arch/arm/plat-s3c24xx/built-in.o:(.data+0x13f4): undefined reference to
`s3c_gpio_getpull_1up'
arch/arm/plat-s3c24xx/built-in.o:(.data+0x13f8): undefined reference to
`s3c_gpio_setpull_1up'

The s3c2442 has pulldowns instead of pullups compared to the s3c2440.
The method of controlling them is the same though.
So this patch modifies the existing s3c_gpio_{get,set}pull_1up helper functions
to take an additional parameter deciding whether the pin has a pullup or pulldown.
The s3c_gpio_{get,set}pull_1{down,up} functions then wrap that functions passing
either S3C_GPIO_PULL_UP or S3C_GPIO_PULL_DOWN.

Furthermore this patch sets up the s3c24xx_gpiocfg_default.{get,set}_pull fields
in the s3c244{0,2}_map_io function to the new pulldown helper functions.

Based on patch from "Lars-Peter Clausen" <lars@metafoo.de>

Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
2010-12-08 01:04:56 +00:00
..
include/plat ARM: S3C24XX: Fix mess with gpio {set,get}_pull callbacks 2010-12-08 01:04:56 +00:00
adc.c ARM: SAMSUNG: Fix build warnings because of unused codes 2010-10-08 13:50:17 +09:00
clock-clksrc.c
clock.c ARM: SAMSUNG: Add a workaround for get_clock() for serial driver 2010-10-08 13:50:18 +09:00
dev-adc.c ARM: SAMSUNG: Moving ADC device definition to plat-samsung. 2010-05-18 13:38:44 +09:00
dev-fb.c ARM: SAMSUNG: Set S3C_FB_MAX_WIN in <plat/fb.h> 2010-05-18 18:46:27 +09:00
dev-hsmmc1.c ARM: SAMSUNG: Add clock types into platform data 2010-10-25 16:02:47 +09:00
dev-hsmmc2.c ARM: SAMSUNG: Add clock types into platform data 2010-10-25 16:02:47 +09:00
dev-hsmmc3.c ARM: SAMSUNG: Add clock types into platform data 2010-10-25 16:02:47 +09:00
dev-hsmmc.c ARM: SAMSUNG: Add clock types into platform data 2010-10-25 16:02:47 +09:00
dev-hwmon.c ARM: SAMSUNG: Move HWMON from plat-s3c24xx to plat-samsung 2010-05-12 17:43:03 +09:00
dev-i2c0.c include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h 2010-03-30 22:02:32 +09:00
dev-i2c1.c include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h 2010-03-30 22:02:32 +09:00
dev-i2c2.c ARM: S5PV210: Fix wrong interrupt I2C2 and I2C3 number 2010-10-25 16:03:27 +09:00
dev-i2c3.c ARM: S5PV310: Add I2C channel 3, 4, 5, 6, and 7 device support 2010-10-25 16:03:43 +09:00
dev-i2c4.c ARM: S5PV310: Add I2C channel 3, 4, 5, 6, and 7 device support 2010-10-25 16:03:43 +09:00
dev-i2c5.c ARM: S5PV310: Add I2C channel 3, 4, 5, 6, and 7 device support 2010-10-25 16:03:43 +09:00
dev-i2c6.c ARM: S5PV310: Add I2C channel 3, 4, 5, 6, and 7 device support 2010-10-25 16:03:43 +09:00
dev-i2c7.c ARM: S5PV310: Add I2C channel 3, 4, 5, 6, and 7 device support 2010-10-25 16:03:43 +09:00
dev-ide.c ARM: SAMSUNG: Add Compact Flash device support for Samsung SoCs 2010-08-05 18:32:50 +09:00
dev-keypad.c ARM: SAMSUNG: Add keypad device support 2010-08-06 21:27:50 +09:00
dev-nand.c include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h 2010-03-30 22:02:32 +09:00
dev-onenand.c ARM: SAMSUNG: Add platform support code for OneNAND controller 2010-05-20 17:48:36 +09:00
dev-rtc.c ARM: SAMSUNG: Move RTC device definitions in plat-samsung 2010-05-18 16:44:58 +09:00
dev-ts.c ARM: SAMSUNG: Move s3c64xx dev-ts.c to plat-samsung and rename configuration 2010-05-19 18:25:30 +09:00
dev-uart.c
dev-usb-hsotg.c
dev-usb.c include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h 2010-03-30 22:02:32 +09:00
dev-wdt.c ARM: SAMSUNG: Reduce virtual memory size for WDT device 2010-08-05 18:32:49 +09:00
dma.c ARM: SAMSUNG: Move the last build from plat-s3c to plat-samsung 2010-02-23 00:03:43 +00:00
gpio-config.c ARM: S3C24XX: Fix mess with gpio {set,get}_pull callbacks 2010-12-08 01:04:56 +00:00
gpio.c ARM: SAMSUNG: Add common samsung_gpiolib_to_irq function 2010-10-21 07:54:57 +09:00
gpiolib.c ARM: SAMSUNG: Fix on inclusion mach/gpio.h on gpiolib.c 2010-08-06 21:28:39 +09:00
init.c ARM: SAMSUNG: Move the last build from plat-s3c to plat-samsung 2010-02-23 00:03:43 +00:00
irq-uart.c
irq-vic-timer.c
Kconfig ARM: S5PV310: Add I2C channel 3, 4, 5, 6, and 7 device support 2010-10-25 16:03:43 +09:00
Makefile ARM: S5PV310: Add I2C channel 3, 4, 5, 6, and 7 device support 2010-10-25 16:03:43 +09:00
platformdata.c ARM: SAMSUNG: Add helper to clone and set platform data 2010-08-05 18:32:49 +09:00
pm-check.c include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h 2010-03-30 22:02:32 +09:00
pm-gpio.c ARM: S5PV210: Add Power Management Support 2010-10-21 07:54:57 +09:00
pm.c
pwm-clock.c
pwm.c include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h 2010-03-30 22:02:32 +09:00
s3c-pl330.c ARM: SAMSUNG: Move DMA clock enable into S3C PL330 driver 2010-10-25 16:10:56 +09:00
time.c ARM: SAMSUNG: Move the last build from plat-s3c to plat-samsung 2010-02-23 00:03:43 +00:00
wakeup-mask.c ARM: SAMSUNG: Add support for interrupt wakeup-sources 2010-05-20 21:07:01 +09:00