f287083ba7
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
103 lines
2.3 KiB
C
103 lines
2.3 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* INT3402 thermal driver for memory temperature reporting
|
|
*
|
|
* Copyright (C) 2014, Intel Corporation
|
|
* Authors: Aaron Lu <aaron.lu@intel.com>
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/acpi.h>
|
|
#include <linux/thermal.h>
|
|
#include "int340x_thermal_zone.h"
|
|
|
|
#define INT3402_PERF_CHANGED_EVENT 0x80
|
|
#define INT3402_THERMAL_EVENT 0x90
|
|
|
|
struct int3402_thermal_data {
|
|
acpi_handle *handle;
|
|
struct int34x_thermal_zone *int340x_zone;
|
|
};
|
|
|
|
static void int3402_notify(acpi_handle handle, u32 event, void *data)
|
|
{
|
|
struct int3402_thermal_data *priv = data;
|
|
|
|
if (!priv)
|
|
return;
|
|
|
|
switch (event) {
|
|
case INT3402_PERF_CHANGED_EVENT:
|
|
break;
|
|
case INT3402_THERMAL_EVENT:
|
|
int340x_thermal_zone_device_update(priv->int340x_zone,
|
|
THERMAL_TRIP_VIOLATED);
|
|
break;
|
|
default:
|
|
break;
|
|
}
|
|
}
|
|
|
|
static int int3402_thermal_probe(struct platform_device *pdev)
|
|
{
|
|
struct acpi_device *adev = ACPI_COMPANION(&pdev->dev);
|
|
struct int3402_thermal_data *d;
|
|
int ret;
|
|
|
|
if (!acpi_has_method(adev->handle, "_TMP"))
|
|
return -ENODEV;
|
|
|
|
d = devm_kzalloc(&pdev->dev, sizeof(*d), GFP_KERNEL);
|
|
if (!d)
|
|
return -ENOMEM;
|
|
|
|
d->int340x_zone = int340x_thermal_zone_add(adev, NULL);
|
|
if (IS_ERR(d->int340x_zone))
|
|
return PTR_ERR(d->int340x_zone);
|
|
|
|
ret = acpi_install_notify_handler(adev->handle,
|
|
ACPI_DEVICE_NOTIFY,
|
|
int3402_notify,
|
|
d);
|
|
if (ret) {
|
|
int340x_thermal_zone_remove(d->int340x_zone);
|
|
return ret;
|
|
}
|
|
|
|
d->handle = adev->handle;
|
|
platform_set_drvdata(pdev, d);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void int3402_thermal_remove(struct platform_device *pdev)
|
|
{
|
|
struct int3402_thermal_data *d = platform_get_drvdata(pdev);
|
|
|
|
acpi_remove_notify_handler(d->handle,
|
|
ACPI_DEVICE_NOTIFY, int3402_notify);
|
|
int340x_thermal_zone_remove(d->int340x_zone);
|
|
}
|
|
|
|
static const struct acpi_device_id int3402_thermal_match[] = {
|
|
{"INT3402", 0},
|
|
{}
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(acpi, int3402_thermal_match);
|
|
|
|
static struct platform_driver int3402_thermal_driver = {
|
|
.probe = int3402_thermal_probe,
|
|
.remove_new = int3402_thermal_remove,
|
|
.driver = {
|
|
.name = "int3402 thermal",
|
|
.acpi_match_table = int3402_thermal_match,
|
|
},
|
|
};
|
|
|
|
module_platform_driver(int3402_thermal_driver);
|
|
|
|
MODULE_DESCRIPTION("INT3402 Thermal driver");
|
|
MODULE_LICENSE("GPL");
|