471ef0b5a8
GCC's named address space checks errors out with:
drivers/clocksource/timer-of.c: In function ‘timer_of_irq_exit’:
drivers/clocksource/timer-of.c:29:46: error: passing argument 2 of
‘free_percpu_irq’ from pointer to non-enclosed address space
29 | free_percpu_irq(of_irq->irq, clkevt);
| ^~~~~~
In file included from drivers/clocksource/timer-of.c:8:
./include/linux/interrupt.h:201:43: note: expected ‘__seg_gs void *’
but argument is of type ‘struct clock_event_device *’
201 | extern void free_percpu_irq(unsigned int, void __percpu *);
| ^~~~~~~~~~~~~~~
drivers/clocksource/timer-of.c: In function ‘timer_of_irq_init’:
drivers/clocksource/timer-of.c:74:51: error: passing argument 4 of
‘request_percpu_irq’ from pointer to non-enclosed address space
74 | np->full_name, clkevt) :
| ^~~~~~
./include/linux/interrupt.h:190:56: note: expected ‘__seg_gs void *’
but argument is of type ‘struct clock_event_device *’
190 | const char *devname, void __percpu *percpu_dev_id)
Sparse warns about:
timer-of.c:29:46: warning: incorrect type in argument 2 (different address spaces)
timer-of.c:29:46: expected void [noderef] __percpu *
timer-of.c:29:46: got struct clock_event_device *clkevt
timer-of.c:74:51: warning: incorrect type in argument 4 (different address spaces)
timer-of.c:74:51: expected void [noderef] __percpu *percpu_dev_id
timer-of.c:74:51: got struct clock_event_device *clkevt
It appears the code is incorrect as reported by Uros Bizjak:
"The referred code is questionable as it tries to reuse
the clkevent pointer once as percpu pointer and once as generic
pointer, which should be avoided."
This change removes the percpu related code as no drivers is using it.
[Daniel: Fixed the description]
Fixes: dc11bae785 ("clocksource/drivers: Add timer-of common init routine")
Reported-by: Uros Bizjak <ubizjak@gmail.com>
Tested-by: Uros Bizjak <ubizjak@gmail.com>
Link: https://lore.kernel.org/r/20240819100335.2394751-1-daniel.lezcano@linaro.org
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
74 lines
1.3 KiB
C
74 lines
1.3 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef __TIMER_OF_H__
|
|
#define __TIMER_OF_H__
|
|
|
|
#include <linux/clockchips.h>
|
|
|
|
#define TIMER_OF_BASE 0x1
|
|
#define TIMER_OF_CLOCK 0x2
|
|
#define TIMER_OF_IRQ 0x4
|
|
|
|
struct of_timer_irq {
|
|
int irq;
|
|
int index;
|
|
const char *name;
|
|
unsigned long flags;
|
|
irq_handler_t handler;
|
|
};
|
|
|
|
struct of_timer_base {
|
|
void __iomem *base;
|
|
const char *name;
|
|
int index;
|
|
};
|
|
|
|
struct of_timer_clk {
|
|
struct clk *clk;
|
|
const char *name;
|
|
int index;
|
|
unsigned long rate;
|
|
unsigned long period;
|
|
};
|
|
|
|
struct timer_of {
|
|
unsigned int flags;
|
|
struct device_node *np;
|
|
struct clock_event_device clkevt;
|
|
struct of_timer_base of_base;
|
|
struct of_timer_irq of_irq;
|
|
struct of_timer_clk of_clk;
|
|
void *private_data;
|
|
};
|
|
|
|
static inline struct timer_of *to_timer_of(struct clock_event_device *clkevt)
|
|
{
|
|
return container_of(clkevt, struct timer_of, clkevt);
|
|
}
|
|
|
|
static inline void __iomem *timer_of_base(struct timer_of *to)
|
|
{
|
|
return to->of_base.base;
|
|
}
|
|
|
|
static inline int timer_of_irq(struct timer_of *to)
|
|
{
|
|
return to->of_irq.irq;
|
|
}
|
|
|
|
static inline unsigned long timer_of_rate(struct timer_of *to)
|
|
{
|
|
return to->of_clk.rate;
|
|
}
|
|
|
|
static inline unsigned long timer_of_period(struct timer_of *to)
|
|
{
|
|
return to->of_clk.period;
|
|
}
|
|
|
|
extern int __init timer_of_init(struct device_node *np,
|
|
struct timer_of *to);
|
|
|
|
extern void __init timer_of_cleanup(struct timer_of *to);
|
|
|
|
#endif
|