kevin/linux
1
Fork 0
Code
c1d390d8e6
linux/drivers/scsi/megaraid
History
Xiaotian Feng c1d390d8e6 megaraid: fix BUG_ON() from incorrect use of delayed work 
megaraid use INIT_WORK to declare a hotplug_work, but cast the
hotplug_work from work_struct to delayed_work and
schedule_delayed_work on it.  This is very dangerous, as other part of
delayed_work might be kernel memories allocated by others.

With commit 8852aac ("workqueue: mod_delayed_work_on() shouldn't queue
timer on 0 delay"), schedule_delayed_work() will check dwork->timer
before queue_work even when @delay is 0, this causes megaraid code to
hit the BUG_ON() in workqueue code.  Change megaraid code to use
delayed work.

Signed-off-by: Xiaotian Feng <dannyfeng@tencent.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Neela Syam Kolli <megaraidlinux@lsi.com>
Cc: "James E.J. Bottomley" <JBottomley@parallels.com>
Cc: linux-scsi@vger.kernel.org
2012-12-04 07:29:47 -08:00
..
Kconfig.megaraid
Makefile
mbox_defs.h Fix common misspellings 2011-03-31 11:26:23 -03:00
mega_common.h
megaraid_ioctl.h
megaraid_mbox.c [SCSI] megaraid: remove a spurious IRQ enable 2012-07-20 08:58:39 +01:00
megaraid_mbox.h
megaraid_mm.c
megaraid_mm.h
megaraid_sas_base.c megaraid: fix BUG_ON() from incorrect use of delayed work 2012-12-04 07:29:47 -08:00
megaraid_sas_fp.c [SCSI] megaraid_sas: Version, Changelog, Copyright update 2012-10-09 11:21:48 +01:00
megaraid_sas_fusion.c [SCSI] megaraid_sas: Version, Changelog, Copyright update 2012-10-09 11:21:48 +01:00
megaraid_sas_fusion.h [SCSI] megaraid_sas: Version, Changelog, Copyright update 2012-10-09 11:21:48 +01:00
megaraid_sas.h megaraid: fix BUG_ON() from incorrect use of delayed work 2012-12-04 07:29:47 -08:00