1
linux/fs/9p
Dominique Martinet e3786b29c5
9p: Fix DIO read through netfs
If a program is watching a file on a 9p mount, it won't see any change in
size if the file being exported by the server is changed directly in the
source filesystem, presumably because 9p doesn't have change notifications,
and because netfs skips the reads if the file is empty.

Fix this by attempting to read the full size specified when a DIO read is
requested (such as when 9p is operating in unbuffered mode) and dealing
with a short read if the EOF was less than the expected read.

To make this work, filesystems using netfslib must not set
NETFS_SREQ_CLEAR_TAIL if performing a DIO read where that read hit the EOF.
I don't want to mandatorily clear this flag in netfslib for DIO because,
say, ceph might make a read from an object that is not completely filled,
but does not reside at the end of file - and so we need to clear the
excess.

This can be tested by watching an empty file over 9p within a VM (such as
in the ktest framework):

        while true; do read content; if [ -n "$content" ]; then echo $content; break; fi; done < /host/tmp/foo

then writing something into the empty file.  The watcher should immediately
display the file content and break out of the loop.  Without this fix, it
remains in the loop indefinitely.

Fixes: 80105ed2fd ("9p: Use netfslib read/write_iter")
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218916
Signed-off-by: David Howells <dhowells@redhat.com>
Link: https://lore.kernel.org/r/1229195.1723211769@warthog.procyon.org.uk
cc: Eric Van Hensbergen <ericvh@kernel.org>
cc: Latchesar Ionkov <lucho@ionkov.net>
cc: Christian Schoenebeck <linux_oss@crudebyte.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: Ilya Dryomov <idryomov@gmail.com>
cc: Steve French <sfrench@samba.org>
cc: Paulo Alcantara <pc@manguebit.com>
cc: Trond Myklebust <trond.myklebust@hammerspace.com>
cc: v9fs@lists.linux.dev
cc: linux-afs@lists.infradead.org
cc: ceph-devel@vger.kernel.org
cc: linux-cifs@vger.kernel.org
cc: linux-nfs@vger.kernel.org
cc: netfs@lists.linux.dev
cc: linux-fsdevel@vger.kernel.org
Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
2024-08-13 13:53:09 +02:00
..
acl.c
acl.h
cache.c
cache.h
fid.c
fid.h fs/9p: fix the cache always being enabled on files with qid flags 2024-03-28 15:10:29 +00:00
Kconfig
Makefile
v9fs_vfs.h fs/9p: simplify iget to remove unnecessary paths 2024-01-26 16:46:56 +00:00
v9fs.c mm, slab: remove last vestiges of SLAB_MEM_SPREAD 2024-03-12 20:32:19 -07:00
v9fs.h fs/9p: mitigate inode collisions 2024-04-22 15:34:27 +00:00
vfs_addr.c 9p: Fix DIO read through netfs 2024-08-13 13:53:09 +02:00
vfs_dentry.c 9p: add missing locking around taking dentry fid list 2024-05-23 20:29:09 +09:00
vfs_dir.c fs/9p: rework qid2ino logic 2024-01-26 16:46:56 +00:00
vfs_file.c 9p: explicitly deny setlease attempts 2024-03-28 19:52:55 +00:00
vfs_inode_dotl.c fs/9p: mitigate inode collisions 2024-04-22 15:34:27 +00:00
vfs_inode.c netfs, 9p: Fix race between umount and async request completion 2024-05-27 13:12:13 +02:00
vfs_super.c fs/9p: mitigate inode collisions 2024-04-22 15:34:27 +00:00
xattr.c Bunch of small fixes: 2023-11-04 09:20:04 -10:00
xattr.h 9p: move xattr-related structs to .rodata 2023-10-09 16:24:16 +02:00