414d0f45c3
Currently lists are being used to manage this, but best practice is usually to have these in an array instead as that it cheaper to manage. Outside of that detail, games are also played with KASAN as the list is inside the cached entry itself. Finally, all users of this need a struct io_cache_entry embedded in their struct, which is union'ized with something else in there that isn't used across the free -> realloc cycle. Get rid of all of that, and simply have it be an array. This will not change the memory used, as we're just trading an 8-byte member entry for the per-elem array size. This reduces the overhead of the recycled allocations, and it reduces the amount of code code needed to support recycling to about half of what it currently is. Signed-off-by: Jens Axboe <axboe@kernel.dk>
62 lines
1.3 KiB
C
62 lines
1.3 KiB
C
#ifndef IOU_ALLOC_CACHE_H
|
|
#define IOU_ALLOC_CACHE_H
|
|
|
|
/*
|
|
* Don't allow the cache to grow beyond this size.
|
|
*/
|
|
#define IO_ALLOC_CACHE_MAX 128
|
|
|
|
static inline bool io_alloc_cache_put(struct io_alloc_cache *cache,
|
|
void *entry)
|
|
{
|
|
if (cache->nr_cached < cache->max_cached) {
|
|
if (!kasan_mempool_poison_object(entry))
|
|
return false;
|
|
cache->entries[cache->nr_cached++] = entry;
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
static inline void *io_alloc_cache_get(struct io_alloc_cache *cache)
|
|
{
|
|
if (cache->nr_cached) {
|
|
void *entry = cache->entries[--cache->nr_cached];
|
|
|
|
kasan_mempool_unpoison_object(entry, cache->elem_size);
|
|
return entry;
|
|
}
|
|
|
|
return NULL;
|
|
}
|
|
|
|
/* returns false if the cache was initialized properly */
|
|
static inline bool io_alloc_cache_init(struct io_alloc_cache *cache,
|
|
unsigned max_nr, size_t size)
|
|
{
|
|
cache->entries = kvmalloc_array(max_nr, sizeof(void *), GFP_KERNEL);
|
|
if (cache->entries) {
|
|
cache->nr_cached = 0;
|
|
cache->max_cached = max_nr;
|
|
cache->elem_size = size;
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
static inline void io_alloc_cache_free(struct io_alloc_cache *cache,
|
|
void (*free)(const void *))
|
|
{
|
|
void *entry;
|
|
|
|
if (!cache->entries)
|
|
return;
|
|
|
|
while ((entry = io_alloc_cache_get(cache)) != NULL)
|
|
free(entry);
|
|
|
|
kvfree(cache->entries);
|
|
cache->entries = NULL;
|
|
}
|
|
#endif
|