kevin/linux
1
Fork 0
Code
a96ca105a6
linux/drivers/char
History
Jesper Juhl a96ca105a6 mga_dma: return 'err' not just zero from mga_do_cleanup_dma() 
While reading some code I stumbled across the use of 'err' in
drivers/char/drm/mga_dma.c::mga_do_cleanup_dma() and I think there's a small
problem.

The variable is only used inside #if __OS_HAS_AGP which is fine, but all that
ever happens is an assignment to the variable - it is never actually used for
anything.  The variable is nicely initialized to zero which is also what the
return statement at the end of function returns (always at the moment).

It looks to me like that function should be returning 'err' instead of always
just returning 0.  Here's a patch to do that.

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Dave Airlie <airlied@linux.ie>
2008-02-07 15:09:39 +10:00
..
agp Merge branch 'agp-patches' of git://git.kernel.org/pub/scm/linux/kernel/git/airlied/agp-2.6 2008-02-05 09:54:10 -08:00
drm mga_dma: return 'err' not just zero from mga_do_cleanup_dma() 2008-02-07 15:09:39 +10:00
hw_random via-rng: enable secondary noise source on CPUs where it is present 2008-02-06 10:41:05 -08:00
ip2 drivers/char/: Spelling fixes 2008-02-03 17:11:42 +02:00
ipmi drivers/char/ipmi/ipmi_msghandler.c: use LIST_HEAD instead of LIST_HEAD_INIT 2008-02-06 10:41:07 -08:00
mwave
pcmcia synclink: standardize format of linux header file include's with "<>" 2008-02-06 10:41:06 -08:00
rio long vs. unsigned long - low-hanging fruits in drivers 2007-10-14 12:41:51 -07:00
tpm tpm: infineon section mismatch 2008-02-06 10:41:10 -08:00
.gitignore
amiserial.c some kmalloc/memset ->kzalloc (tree wide) 2007-07-19 10:04:50 -07:00
apm-emulation.c Freezer: Fix APM emulation breakage 2007-11-20 22:28:20 -05:00
applicom.c
applicom.h
briq_panel.c [POWERPC] Remove dead code for preventing pread() and pwrite() calls 2007-07-10 22:03:26 +10:00
cd1865.h
ChangeLog
consolemap.c unicode diacritics support 2007-10-17 08:42:52 -07:00
cp437.uni
cs5535_gpio.c gpio_cs5535: disable AUX on output 2007-12-05 09:21:20 -08:00
cyclades.c Char: cyclades, fix potential NULL dereference 2007-10-23 08:32:06 -07:00
defkeymap.c_shipped unicode diacritics support 2007-10-17 08:42:52 -07:00
defkeymap.map
digi1.h
digiFep1.h
digiPCI.h
ds1286.c
ds1302.c
ds1620.c
dsp56k.c long vs. unsigned long - low-hanging fruits in drivers 2007-10-14 12:41:51 -07:00
dtlk.c
efirtc.c drivers/char/: Spelling fixes 2008-02-03 17:11:42 +02:00
epca.c drivers/char/: Spelling fixes 2008-02-03 17:11:42 +02:00
epca.h
epcaconfig.h
esp.c Convert files to UTF-8 and some cleanups 2007-10-19 23:21:04 +02:00
generic_nvram.c
generic_serial.c genericserial: remove bogus optimisation check and dead code paths 2007-07-16 09:05:51 -07:00
genrtc.c Char: genrtc, use wait_event_interruptible 2007-07-16 09:05:44 -07:00
hangcheck-timer.c drivers/char/: Spelling fixes 2008-02-03 17:11:42 +02:00
hpet.c x86: nuke a ton of dead hpet code 2008-01-30 13:30:27 +01:00
hvc_beat.c [POWERPC] Init markings for hvc_beat 2007-08-17 11:01:50 +10:00
hvc_console.c drivers/char: use LIST_HEAD instead of LIST_HEAD_INIT 2008-02-06 10:41:07 -08:00
hvc_console.h
hvc_iseries.c [POWERPC] init and exit markings for hvc_iseries 2007-07-22 21:30:59 +10:00
hvc_rtas.c [POWERPC] Quiet section mismatch in hvc_rtas.c 2007-07-22 21:30:59 +10:00
hvc_vio.c
hvc_xen.c xen: use the hvc console infrastructure for Xen console 2007-07-18 08:47:44 -07:00
hvcs.c drivers/char: use LIST_HEAD instead of LIST_HEAD_INIT 2008-02-06 10:41:07 -08:00
hvsi.c
i8k.c ik8: add Dell UK 6400 Inspiron model (MM061) 2008-02-06 10:41:08 -08:00
ip27-rtc.c ip27-rtc: convert ioctl to unlocked_ioctl 2008-02-06 10:41:14 -08:00
isicom.c Add missing newlines to some uses of dev_<level> messages 2007-10-18 14:37:28 -07:00
istallion.c Convert from class_device to device in drivers/char 2007-10-12 14:51:04 -07:00
Kconfig char: use SGI_HAS_DS1286 for SGI_DS1286 depends 2008-02-06 10:41:06 -08:00
keyboard.c get rid of input BIT* duplicate defines 2007-10-19 11:53:42 -07:00
lcd.c [MIPS] Delete duplicate inclusion of <linux/delay.h>. 2007-08-27 02:16:59 +01:00
lcd.h
lp.c Parallel port: convert port_mutex to the mutex API 2008-02-06 10:41:01 -08:00
Makefile nozomi driver 2008-01-24 20:40:04 -08:00
mbcs.c Clean up duplicate includes in drivers/char/ 2007-10-17 08:42:48 -07:00
mbcs.h mbcs: Remove lots of global symbols 2007-07-19 10:04:43 -07:00
mem.c x86 merge fallout: uml 2007-10-29 07:41:32 -07:00
misc.c Misc: Add possibility to remove misc devices during suspend/resume 2008-02-05 09:44:23 -08:00
mmtimer.c Remove fs.h from mm.h 2007-07-29 17:09:29 -07:00
moxa.c Char: moxa, remove sleep_on 2007-10-18 14:37:27 -07:00
mspec.c vm audit: add VM_DONTEXPAND to mmap for drivers that need it 2008-02-04 07:55:38 -08:00
mxser_new.c Remove inclusions of <linux/autoconf.h> 2008-02-06 10:41:00 -08:00
mxser_new.h
mxser.c Remove inclusions of <linux/autoconf.h> 2008-02-06 10:41:00 -08:00
mxser.h mxser: Remove use of dead TTY_FLIPBUF_SIZE definition 2007-10-17 08:42:52 -07:00
n_hdlc.c n_hdlc.c: fix check-after-use 2007-10-17 08:42:55 -07:00
n_r3964.c Char: n_r3964, use wait_event_interruptible 2007-07-16 09:05:44 -07:00
n_tty.c Fix IXANY and restart after signal (e.g. ctrl-C) in n_tty line discipline 2008-02-06 10:41:09 -08:00
nozomi.c nozomi: finish constification 2008-02-02 15:14:48 -08:00
nsc_gpio.c
nvram.c COBALT: remove all references to Cobalt NVRAM 2007-07-16 09:05:47 -07:00
nwbutton.c
nwbutton.h
nwflash.c
pc8736x_gpio.c
ppdev.c [PARPORT] Remove unused 'irq' argument from parport irq functions 2007-10-23 19:53:16 -04:00
ps3flash.c ps3: FLASH ROM Storage Driver 2007-07-21 17:49:16 -07:00
pty.c sysctl: simplify the pty sysctl logic 2007-10-18 14:37:23 -07:00
random.c drivers/char/random.c:write_pool() cond_resched() needed 2008-02-06 10:41:06 -08:00
raw.c cdev: remove unneeded setting of cdev names 2007-10-12 14:51:02 -07:00
riscom8_reg.h
riscom8.c riscom8: fix SMP brokenness 2008-02-06 10:41:00 -08:00
riscom8.h long vs. unsigned long - low-hanging fruits in drivers 2007-10-14 12:41:51 -07:00
rocket_int.h Char: rocket, switch sleep_on to completion 2007-10-18 14:37:27 -07:00
rocket.c Fix misspellings of "system", "controller", "interrupt" and "necessary". 2007-10-19 23:10:43 +02:00
rocket.h
rtc.c rtc: use the IRQ callback interface in (old) RTC driver 2008-01-30 13:33:31 +01:00
scc.h
scx200_gpio.c
selection.c Kernel utf-8 handling 2007-07-16 09:05:46 -07:00
ser_a2232.c Amiga serial driver: port_write_mutex fixup 2008-02-06 10:41:08 -08:00
ser_a2232.h
ser_a2232fw.ax
ser_a2232fw.h
serial167.c m68k: remove empty ->setup is several consoles 2007-07-20 08:24:49 -07:00
snsc_event.c
snsc.c Convert from class_device to device in drivers/char 2007-10-12 14:51:04 -07:00
snsc.h
sonypi.c Sonypi: use synchronize_irq instead of sycnronize_sched 2007-11-21 14:16:38 -05:00
specialix_io8.h
specialix.c Char: specialix, remove busy waiting 2007-07-17 10:23:10 -07:00
stallion.c Convert from class_device to device in drivers/char 2007-10-12 14:51:04 -07:00
sx.c Use helpers to obtain task pid in printks 2007-10-19 11:53:43 -07:00
sx.h long vs. unsigned long - low-hanging fruits in drivers 2007-10-14 12:41:51 -07:00
sxboards.h
sxwindow.h
synclink_gt.c synclink_gt fix missed serial input signal changes 2008-02-06 10:41:06 -08:00
synclink.c synclink: standardize format of linux header file include's with "<>" 2008-02-06 10:41:06 -08:00
synclinkmp.c synclink: standardize format of linux header file include's with "<>" 2008-02-06 10:41:06 -08:00
sysrq.c pid namespaces: define is_global_init() and is_container_init() 2007-10-19 11:53:37 -07:00
tb0219.c
tlclk.c
toshiba.c drivers/char/: Spelling fixes 2008-02-03 17:11:42 +02:00
tty_audit.c [AUDIT] add session id to audit messages 2008-02-01 14:06:51 -05:00
tty_io.c unix98 allocated_ptys_lock semaphore to mutex 2008-02-06 10:41:07 -08:00
tty_ioctl.c pl2303: Fix mode switching regression 2008-01-08 16:16:34 -08:00
vc_screen.c
viocons.c
viotape.c Convert from class_device to device in drivers/char 2007-10-12 14:51:04 -07:00
virtio_console.c virtio: simplify config mechanism. 2008-02-04 23:49:57 +11:00
vme_scc.c m68k: remove empty ->setup is several consoles 2007-07-20 08:24:49 -07:00
vr41xx_giu.c [MIPS] Separate platform_device registration for VR41xx GPIO 2007-07-12 17:41:15 +01:00
vt_ioctl.c add CONFIG_VT_UNICODE 2007-10-17 08:42:56 -07:00
vt.c vt: bitlock fix 2008-02-06 10:41:04 -08:00