fbae3fb154
I2C drivers can use the clientdata-pointer to point to private data. As I2C
devices are not really unregistered, but merely detached from their driver, it
used to be the drivers obligation to clear this pointer during remove() or a
failed probe(). As a couple of drivers forgot to do this, it was agreed that it
was cleaner if the i2c-core does this clearance when appropriate, as there is
no guarantee for the lifetime of the clientdata-pointer after remove() anyhow.
This feature was added to the core with commit
e4a7b9b04d to fix the faulty drivers.
As there is no need anymore to clear the clientdata-pointer, remove all current
occurrences in the drivers to simplify the code and prevent confusion.
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
Acked-by: Richard Purdie <rpurdie@linux.intel.com>
Acked-by: Dmitry Torokhov <dtor@mail.ru>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
131 lines
2.8 KiB
C
131 lines
2.8 KiB
C
/*
|
|
* wm8350-i2c.c -- Generic I2C driver for Wolfson WM8350 PMIC
|
|
*
|
|
* Copyright 2007, 2008 Wolfson Microelectronics PLC.
|
|
*
|
|
* Author: Liam Girdwood
|
|
* linux@wolfsonmicro.com
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License as published by the
|
|
* Free Software Foundation; either version 2 of the License, or (at your
|
|
* option) any later version.
|
|
*
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/moduleparam.h>
|
|
#include <linux/init.h>
|
|
#include <linux/i2c.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/mfd/wm8350/core.h>
|
|
#include <linux/slab.h>
|
|
|
|
static int wm8350_i2c_read_device(struct wm8350 *wm8350, char reg,
|
|
int bytes, void *dest)
|
|
{
|
|
int ret;
|
|
|
|
ret = i2c_master_send(wm8350->i2c_client, ®, 1);
|
|
if (ret < 0)
|
|
return ret;
|
|
ret = i2c_master_recv(wm8350->i2c_client, dest, bytes);
|
|
if (ret < 0)
|
|
return ret;
|
|
if (ret != bytes)
|
|
return -EIO;
|
|
return 0;
|
|
}
|
|
|
|
static int wm8350_i2c_write_device(struct wm8350 *wm8350, char reg,
|
|
int bytes, void *src)
|
|
{
|
|
/* we add 1 byte for device register */
|
|
u8 msg[(WM8350_MAX_REGISTER << 1) + 1];
|
|
int ret;
|
|
|
|
if (bytes > ((WM8350_MAX_REGISTER << 1) + 1))
|
|
return -EINVAL;
|
|
|
|
msg[0] = reg;
|
|
memcpy(&msg[1], src, bytes);
|
|
ret = i2c_master_send(wm8350->i2c_client, msg, bytes + 1);
|
|
if (ret < 0)
|
|
return ret;
|
|
if (ret != bytes + 1)
|
|
return -EIO;
|
|
return 0;
|
|
}
|
|
|
|
static int wm8350_i2c_probe(struct i2c_client *i2c,
|
|
const struct i2c_device_id *id)
|
|
{
|
|
struct wm8350 *wm8350;
|
|
int ret = 0;
|
|
|
|
wm8350 = kzalloc(sizeof(struct wm8350), GFP_KERNEL);
|
|
if (wm8350 == NULL)
|
|
return -ENOMEM;
|
|
|
|
i2c_set_clientdata(i2c, wm8350);
|
|
wm8350->dev = &i2c->dev;
|
|
wm8350->i2c_client = i2c;
|
|
wm8350->read_dev = wm8350_i2c_read_device;
|
|
wm8350->write_dev = wm8350_i2c_write_device;
|
|
|
|
ret = wm8350_device_init(wm8350, i2c->irq, i2c->dev.platform_data);
|
|
if (ret < 0)
|
|
goto err;
|
|
|
|
return ret;
|
|
|
|
err:
|
|
kfree(wm8350);
|
|
return ret;
|
|
}
|
|
|
|
static int wm8350_i2c_remove(struct i2c_client *i2c)
|
|
{
|
|
struct wm8350 *wm8350 = i2c_get_clientdata(i2c);
|
|
|
|
wm8350_device_exit(wm8350);
|
|
kfree(wm8350);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct i2c_device_id wm8350_i2c_id[] = {
|
|
{ "wm8350", 0 },
|
|
{ "wm8351", 0 },
|
|
{ "wm8352", 0 },
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(i2c, wm8350_i2c_id);
|
|
|
|
|
|
static struct i2c_driver wm8350_i2c_driver = {
|
|
.driver = {
|
|
.name = "wm8350",
|
|
.owner = THIS_MODULE,
|
|
},
|
|
.probe = wm8350_i2c_probe,
|
|
.remove = wm8350_i2c_remove,
|
|
.id_table = wm8350_i2c_id,
|
|
};
|
|
|
|
static int __init wm8350_i2c_init(void)
|
|
{
|
|
return i2c_add_driver(&wm8350_i2c_driver);
|
|
}
|
|
/* init early so consumer devices can complete system boot */
|
|
subsys_initcall(wm8350_i2c_init);
|
|
|
|
static void __exit wm8350_i2c_exit(void)
|
|
{
|
|
i2c_del_driver(&wm8350_i2c_driver);
|
|
}
|
|
module_exit(wm8350_i2c_exit);
|
|
|
|
MODULE_DESCRIPTION("I2C support for the WM8350 AudioPlus PMIC");
|
|
MODULE_LICENSE("GPL");
|