5dd7ed2e81
This patch addresses the majority of sparse warnings and adds proper locking annotations. It also fixes the dubious one-bit signed bitfield, for which the signed one-bit types can be 0 or -1 which can cause a problem if someone ever checks if (foo->lu_gp_assoc == 1). The current code is fine because everyone just checks zero vs non-zero. But Sparse complains about it so lets change it. The warnings look like this: include/target/target_core_base.h:228:26: error: dubious one-bit signed bitfield Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Fubo Chen <fubo.chen@gmail.com> Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org> Signed-off-by: James Bottomley <James.Bottomley@suse.de>
72 lines
1.8 KiB
C
72 lines
1.8 KiB
C
#ifndef TARGET_CORE_RD_H
|
|
#define TARGET_CORE_RD_H
|
|
|
|
#define RD_HBA_VERSION "v4.0"
|
|
#define RD_DR_VERSION "4.0"
|
|
#define RD_MCP_VERSION "4.0"
|
|
|
|
/* Largest piece of memory kmalloc can allocate */
|
|
#define RD_MAX_ALLOCATION_SIZE 65536
|
|
/* Maximum queuedepth for the Ramdisk HBA */
|
|
#define RD_HBA_QUEUE_DEPTH 256
|
|
#define RD_DEVICE_QUEUE_DEPTH 32
|
|
#define RD_MAX_DEVICE_QUEUE_DEPTH 128
|
|
#define RD_BLOCKSIZE 512
|
|
#define RD_MAX_SECTORS 1024
|
|
|
|
/* Used in target_core_init_configfs() for virtual LUN 0 access */
|
|
int __init rd_module_init(void);
|
|
void rd_module_exit(void);
|
|
|
|
#define RRF_EMULATE_CDB 0x01
|
|
#define RRF_GOT_LBA 0x02
|
|
|
|
struct rd_request {
|
|
struct se_task rd_task;
|
|
|
|
/* SCSI CDB from iSCSI Command PDU */
|
|
unsigned char rd_scsi_cdb[TCM_MAX_COMMAND_SIZE];
|
|
/* Offset from start of page */
|
|
u32 rd_offset;
|
|
/* Starting page in Ramdisk for request */
|
|
u32 rd_page;
|
|
/* Total number of pages needed for request */
|
|
u32 rd_page_count;
|
|
/* Scatterlist count */
|
|
u32 rd_size;
|
|
/* Ramdisk device */
|
|
struct rd_dev *rd_dev;
|
|
} ____cacheline_aligned;
|
|
|
|
struct rd_dev_sg_table {
|
|
u32 page_start_offset;
|
|
u32 page_end_offset;
|
|
u32 rd_sg_count;
|
|
struct scatterlist *sg_table;
|
|
} ____cacheline_aligned;
|
|
|
|
#define RDF_HAS_PAGE_COUNT 0x01
|
|
|
|
struct rd_dev {
|
|
int rd_direct;
|
|
u32 rd_flags;
|
|
/* Unique Ramdisk Device ID in Ramdisk HBA */
|
|
u32 rd_dev_id;
|
|
/* Total page count for ramdisk device */
|
|
u32 rd_page_count;
|
|
/* Number of SG tables in sg_table_array */
|
|
u32 sg_table_count;
|
|
u32 rd_queue_depth;
|
|
/* Array of rd_dev_sg_table_t containing scatterlists */
|
|
struct rd_dev_sg_table *sg_table_array;
|
|
/* Ramdisk HBA device is connected to */
|
|
struct rd_host *rd_host;
|
|
} ____cacheline_aligned;
|
|
|
|
struct rd_host {
|
|
u32 rd_host_dev_id_count;
|
|
u32 rd_host_id; /* Unique Ramdisk Host ID */
|
|
} ____cacheline_aligned;
|
|
|
|
#endif /* TARGET_CORE_RD_H */
|