1
linux/drivers/i2c
Julia Lawall da6801e38b i2c-s3c2410: Correct use of ! and &
In commit e6bafba5b4, a bug was fixed that
involved converting !x & y to !(x & y).  The code below shows the same
pattern, and thus should perhaps be fixed in the same way.  In particular,
the result of !readl(i2c->regs + S3C2410_IICCON) & S3C2410_IICCON_IRQEN is
always 0.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@ expression E; constant C; @@
(
  !E & !C
|
- !E & C
+ !(E & C)
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Ben Dooks <ben-linux@fluff.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
2008-10-30 15:55:47 +01:00
..
algos i2c-algo-pcf: Fix typo in debugging log message 2008-10-22 20:21:30 +02:00
busses i2c-s3c2410: Correct use of ! and & 2008-10-30 15:55:47 +01:00
chips i2c: Inform about deprecated chips directory 2008-10-22 20:21:33 +02:00
i2c-boardinfo.c
i2c-core.c i2c: Add info->archdata field 2008-10-22 20:21:33 +02:00
i2c-core.h
i2c-dev.c device create: misc: convert device_create_drvdata to device_create 2008-10-16 09:24:43 -07:00
Kconfig i2c: Let users select algorithm drivers manually again 2008-08-10 22:56:15 +02:00
Makefile