259b93b21a
Probing of regulators can be a slow operation and can contribute to slower boot times. This is especially true if a regulator is turned on at probe time (with regulator-boot-on or regulator-always-on) and the regulator requires delays (off-on-time, ramp time, etc). While the overall kernel is not ready to switch to async probe by default, as per the discussion on the mailing lists [1] it is believed that the regulator subsystem is in good shape and we can move regulator drivers over wholesale. There is no way to just magically opt in all regulators (regulators are just normal drivers like platform_driver), so we set PROBE_PREFER_ASYNCHRONOUS for all regulators found in 'drivers/regulator' individually. Given the number of drivers touched and the impossibility to test this ahead of time, it wouldn't be shocking at all if this caused a regression for someone. If there is a regression caused by this patch, it's likely to be one of the cases talked about in [1]. As a "quick fix", drivers involved in the regression could be fixed by changing them to PROBE_FORCE_SYNCHRONOUS. That being said, the correct fix would be to directly fix the problem that caused the issue with async probe. The approach here follows a similar approach that was used for the mmc subsystem several years ago [2]. In fact, I ran nearly the same python script to auto-generate the changes. The only thing I changed was to search for "i2c_driver", "spmi_driver", and "spi_driver" in addition to "platform_driver". [1] https://lore.kernel.org/r/06db017f-e985-4434-8d1d-02ca2100cca0@sirena.org.uk [2] https://lore.kernel.org/r/20200903232441.2694866-1-dianders@chromium.org/ Signed-off-by: Douglas Anderson <dianders@chromium.org> Link: https://lore.kernel.org/r/20230316125351.1.I2a4677392a38db5758dee0788b2cea5872562a82@changeid Signed-off-by: Mark Brown <broonie@kernel.org>
105 lines
2.7 KiB
C
105 lines
2.7 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Regulator driver for STw4810/STw4811 VMMC regulator.
|
|
*
|
|
* Copyright (C) 2013 ST-Ericsson SA
|
|
* Written on behalf of Linaro for ST-Ericsson
|
|
*
|
|
* Author: Linus Walleij <linus.walleij@linaro.org>
|
|
*/
|
|
|
|
#include <linux/err.h>
|
|
#include <linux/init.h>
|
|
#include <linux/mfd/stw481x.h>
|
|
#include <linux/module.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/regulator/driver.h>
|
|
#include <linux/regulator/of_regulator.h>
|
|
|
|
static const unsigned int stw481x_vmmc_voltages[] = {
|
|
1800000,
|
|
1800000,
|
|
2850000,
|
|
3000000,
|
|
1850000,
|
|
2600000,
|
|
2700000,
|
|
3300000,
|
|
};
|
|
|
|
static const struct regulator_ops stw481x_vmmc_ops = {
|
|
.list_voltage = regulator_list_voltage_table,
|
|
.enable = regulator_enable_regmap,
|
|
.disable = regulator_disable_regmap,
|
|
.is_enabled = regulator_is_enabled_regmap,
|
|
.get_voltage_sel = regulator_get_voltage_sel_regmap,
|
|
.set_voltage_sel = regulator_set_voltage_sel_regmap,
|
|
};
|
|
|
|
static const struct regulator_desc vmmc_regulator = {
|
|
.name = "VMMC",
|
|
.id = 0,
|
|
.ops = &stw481x_vmmc_ops,
|
|
.type = REGULATOR_VOLTAGE,
|
|
.owner = THIS_MODULE,
|
|
.n_voltages = ARRAY_SIZE(stw481x_vmmc_voltages),
|
|
.volt_table = stw481x_vmmc_voltages,
|
|
.enable_time = 200, /* FIXME: look this up */
|
|
.enable_reg = STW_CONF1,
|
|
.enable_mask = STW_CONF1_PDN_VMMC | STW_CONF1_MMC_LS_STATUS,
|
|
.enable_val = STW_CONF1_PDN_VMMC,
|
|
.vsel_reg = STW_CONF1,
|
|
.vsel_mask = STW_CONF1_VMMC_MASK,
|
|
};
|
|
|
|
static int stw481x_vmmc_regulator_probe(struct platform_device *pdev)
|
|
{
|
|
struct stw481x *stw481x = dev_get_platdata(&pdev->dev);
|
|
struct regulator_config config = { };
|
|
struct regulator_dev *rdev;
|
|
int ret;
|
|
|
|
/* First disable the external VMMC if it's active */
|
|
ret = regmap_update_bits(stw481x->map, STW_CONF2,
|
|
STW_CONF2_VMMC_EXT, 0);
|
|
if (ret) {
|
|
dev_err(&pdev->dev, "could not disable external VMMC\n");
|
|
return ret;
|
|
}
|
|
|
|
/* Register VMMC regulator */
|
|
config.dev = &pdev->dev;
|
|
config.driver_data = stw481x;
|
|
config.regmap = stw481x->map;
|
|
config.of_node = pdev->dev.of_node;
|
|
config.init_data = of_get_regulator_init_data(&pdev->dev,
|
|
pdev->dev.of_node,
|
|
&vmmc_regulator);
|
|
|
|
rdev = devm_regulator_register(&pdev->dev, &vmmc_regulator, &config);
|
|
if (IS_ERR(rdev)) {
|
|
dev_err(&pdev->dev,
|
|
"error initializing STw481x VMMC regulator\n");
|
|
return PTR_ERR(rdev);
|
|
}
|
|
|
|
dev_info(&pdev->dev, "initialized STw481x VMMC regulator\n");
|
|
return 0;
|
|
}
|
|
|
|
static const struct of_device_id stw481x_vmmc_match[] = {
|
|
{ .compatible = "st,stw481x-vmmc", },
|
|
{},
|
|
};
|
|
|
|
static struct platform_driver stw481x_vmmc_regulator_driver = {
|
|
.driver = {
|
|
.name = "stw481x-vmmc-regulator",
|
|
.probe_type = PROBE_PREFER_ASYNCHRONOUS,
|
|
.of_match_table = stw481x_vmmc_match,
|
|
},
|
|
.probe = stw481x_vmmc_regulator_probe,
|
|
};
|
|
|
|
module_platform_driver(stw481x_vmmc_regulator_driver);
|