1
linux/drivers/s390
Julia Lawall 9b3efc0133 [S390]: Fix use of skb after netif_rx
Recently, Wang Chen submitted a patch
(d30f53aeb3) to move a call to netif_rx(skb)
after a subsequent reference to skb, because netif_rx may call kfree_skb on
its argument.  netif_rx_ni calls netif_rx, so the same problem occurs in
the files below.

I have left the updating of dev->last_rx after the calls to netif_rx_ni
because it seems time dependent, but moved the other field updates before.

This was found using the following semantic match.
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
expression skb, e,e1;
@@

(
 netif_rx(skb);
|
 netif_rx_ni(skb);
)
  ... when != skb = e
(
  skb = e1
|
* skb
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
2007-12-11 02:45:29 -08:00
..
block [S390] dcssblk: prevent early access without own make_request function 2007-12-04 16:09:57 +01:00
char [S390] struct class_device -> struct device conversion. 2007-10-22 12:52:48 +02:00
cio [S390] cio: add missing reprobe loop end statement 2007-12-04 16:09:57 +01:00
crypto Merge master.kernel.org:/pub/scm/linux/kernel/git/gregkh/driver-2.6 2007-10-12 15:49:37 -07:00
net [S390]: Fix use of skb after netif_rx 2007-12-11 02:45:29 -08:00
scsi [SCSI] zfcp: fix cleanup of dismissed error recovery actions 2007-11-16 13:03:21 -06:00
ebcdic.c
Makefile [S390] Calibrate delay and bogomips. 2007-02-05 21:18:31 +01:00
s390_rdev.c
s390mach.c [S390] cio: replace subchannel evaluation queue with bitmap 2007-04-27 16:01:40 +02:00
s390mach.h [S390] ETR support. 2007-02-05 21:18:19 +01:00
sysinfo.c [S390] Processor degradation notification. 2007-04-27 16:01:46 +02:00