1
linux/arch/m68knommu/kernel
Peter Zijlstra aa02cd2d9b xtime_lock vs update_process_times
Commit d3d74453c3 ("hrtimer: fixup the
HRTIMER_CB_IRQSAFE_NO_SOFTIRQ fallback") broke several archs, and since
only Russell bothered to merge the fix, and Greg to ACK his arch, I'm
sending this for merger.

I have confirmation that the Alpha bit results in a booting kernel.
That leaves: blackfin, frv, sh and sparc untested.

The deadlock in question was found by Russell:

  IRQ handle
    -> timer_tick() - xtime seqlock held for write
      -> update_process_times()
        -> run_local_timers()
          -> hrtimer_run_queues()
            -> hrtimer_get_softirq_time() - tries to get a read lock

Now, Thomas assures me the fix is trivial, only do_timer() needs to be
done under the xtime_lock, and update_process_times() can savely be
removed from under it.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Acked-by: Greg Ungerer <gerg@uclinux.org>
CC: Richard Henderson <rth@twiddle.net>
CC: Bryan Wu <bryan.wu@analog.com>
CC: David Howells <dhowells@redhat.com>
CC: Paul Mundt <lethal@linux-sh.org>
CC: William Irwin <wli@holomorphy.com>
Acked-by: Ingo Molnar <mingo@elte.hu>
Acked-by: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-02-13 13:29:25 -08:00
..
asm-offsets.c
comempci.c
dma.c
entry.S
init_task.c
irq.c
m68k_ksyms.c m68knommu: remove duplicate exports 2008-02-05 09:44:21 -08:00
Makefile
module.c
process.c m68knommu: include linux/fs.h for getname() 2007-08-23 21:32:54 -07:00
ptrace.c
semaphore.c
setup.c procfs: constify function pointer tables 2008-02-08 09:22:38 -08:00
signal.c m68knommu: fix syscall restart handling 2007-10-23 08:32:07 -07:00
sys_m68k.c remove include/asm-*/ipc.h 2007-10-17 08:42:55 -07:00
syscalltable.S timerfd: new timerfd API 2008-02-05 09:44:07 -08:00
time.c xtime_lock vs update_process_times 2008-02-13 13:29:25 -08:00
traps.c
vmlinux.lds.S all archs: consolidate init and exit sections in vmlinux.lds.h 2008-01-28 23:21:17 +01:00