1
linux/drivers/staging/dream
Julia Lawall 2bb6a12a88 Staging: dream: introduce missing kfree
Error handling code following a kmalloc or kzalloc should free the
allocated data.

The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@

x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
     when != if (...) { <+...x...+> }
(
x->f1 = E
|
 (x->f1 == NULL || ...)
|
 f(...,x->f1,...)
)
...>
(
 return \(0\|<+...x...+>\|ptr\);
|
 return@p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
2009-09-15 12:02:34 -07:00
..
camera Staging: dream: introduce missing kfree 2009-09-15 12:02:34 -07:00
qdsp5 staging: Make some structures static 2009-09-15 12:02:24 -07:00
smd staging: Make some structures static 2009-09-15 12:02:24 -07:00
gpio_axis.c Staging: dream: add support for input on GPIO pins 2009-09-15 12:02:05 -07:00
gpio_event.c Staging: dream: add support for input on GPIO pins 2009-09-15 12:02:05 -07:00
gpio_input.c Staging: dream: add support for input on GPIO pins 2009-09-15 12:02:05 -07:00
gpio_matrix.c Staging: dream: add support for input on GPIO pins 2009-09-15 12:02:05 -07:00
gpio_output.c Staging: dream: add support for input on GPIO pins 2009-09-15 12:02:05 -07:00
Kconfig Staging: dream: add support for input on GPIO pins 2009-09-15 12:02:05 -07:00
Makefile Staging: dream: add support for input on GPIO pins 2009-09-15 12:02:05 -07:00
synaptics_i2c_rmi.c Staging: dream: Synaptics touchscreen: check that smbus is available 2009-09-15 12:02:05 -07:00
synaptics_i2c_rmi.h Staging: HTC Dream: touchscreen driver for staging 2009-09-15 12:02:04 -07:00