kevin/linux
1
Fork 0
Code
6cf5767c71
linux/drivers/atm
History
Julia Lawall 6cf5767c71 drivers/atm: Correct redundant test 
str has already been tested.  It seems that this test should be on the
recently returned value snr.

A simplified version of the semantic match that finds this problem is as
follows: (http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
expression E;
@@

if (x == NULL || ...) { ... when forall
   return ...; }
... when != \(x=E\|x--\|x++\|--x\|++x\|x-=E\|x+=E\|x|=E\|x&=E\|&x\)
(
*x == NULL
|
*x != NULL
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
2009-07-27 11:38:52 -07:00
..
.gitignore
adummy.c removed unused #include <linux/version.h>'s 2008-08-23 12:14:12 -07:00
ambassador.c firmware: convert Ambassador ATM driver to request_firmware() 2008-07-10 14:49:39 +01:00
ambassador.h firmware: convert Ambassador ATM driver to request_firmware() 2008-07-10 14:49:39 +01:00
atmtcp.c
eni.c drivers/atm: Use DIV_ROUND_UP 2008-09-22 19:22:58 -07:00
eni.h drivers/atm/eni.h: remove unused macro KERNEL_OFFSET 2008-06-10 12:46:52 -07:00
firestream.c atm: Add missing parentheses 2009-02-18 19:35:17 -08:00
firestream.h
fore200e.c fore200: fix oops on failed firmware load 2009-02-10 17:19:19 -08:00
fore200e.h fore200e: Convert over to pure OF driver. 2008-08-29 02:14:59 -07:00
he.c dma-mapping: replace all DMA_32BIT_MASK macro with DMA_BIT_MASK(32) 2009-04-07 08:31:11 -07:00
he.h atm: [he] remove #ifdef clutter 2008-06-17 16:21:44 -07:00
horizon.c ATM: horizon, fix hrz_probe fail path 2008-11-29 20:42:28 -08:00
horizon.h long vs. unsigned long - low-hanging fruits in drivers 2007-10-14 12:41:51 -07:00
idt77105.c [ATM] atm/idt77105.c: Fix section mismatch. 2008-01-20 20:31:43 -08:00
idt77105.h
idt77252_tables.h
idt77252.c atm: idt77252: Use generic SKB queue management instead of home-grown scheme. 2008-09-21 21:38:26 -07:00
idt77252.h atm: idt77252: Use generic SKB queue management instead of home-grown scheme. 2008-09-21 21:38:26 -07:00
iphase.c atm: fix non-const printk argument 2009-03-21 19:06:51 -07:00
iphase.h iphase: Fix 64bit warning. 2008-05-14 23:28:47 -07:00
Kconfig atm: Driver for Solos PCI ADSL2+ card. 2008-12-26 01:26:11 -08:00
lanai.c dma-mapping: replace all DMA_32BIT_MASK macro with DMA_BIT_MASK(32) 2009-04-07 08:31:11 -07:00
Makefile atm: Driver for Solos PCI ADSL2+ card. 2008-12-26 01:26:11 -08:00
midway.h
nicstar.c drivers: atm, char fix integer as NULL pointer warnings 2008-04-28 17:29:18 -07:00
nicstar.h atm nicstar: Removal of debug code containing deprecated calls to cli()/sti() 2008-04-19 18:10:46 -07:00
nicstarmac.c [ATM]: [nicstar] Replace C code with call to ARRAY_SIZE() macro. 2007-07-18 01:46:53 -07:00
nicstarmac.copyright drivers/atm/: remove CVS keywords 2008-05-20 14:52:25 -07:00
solos-attrlist.c solos: Add initial list of parameters 2009-01-27 16:52:07 +11:00
solos-pci.c drivers/atm: Correct redundant test 2009-07-27 11:38:52 -07:00
suni.c atm: [suni] add support for setting loopback and framing modes 2008-06-17 16:19:24 -07:00
suni.h atm: [suni] add support for setting loopback and framing modes 2008-06-17 16:19:24 -07:00
tonga.h
uPD98401.h
uPD98402.c
uPD98402.h
zatm.c drivers/atm: Use DIV_ROUND_UP 2008-09-22 19:22:58 -07:00
zatm.h
zeprom.h