Boaz Harrosh 9337057d43 um: Proper Fix for f25c80a4: remove duplicate structure field initialization ... uml_net_set_mac() was broken and luckily it was never used, before. What it was trying to do is spin_lock before memcopy the mac address. Linus attempted to fix it in assumption that someone decided the lock was needed. But since it was never ever used at all, and was just dead code, I think we can assume that it is not needed, after all. On the other hand patch [f25c80a4] was trying to use eth_mac_addr() in eth_configure(), *which was the real fallout*. Because of state checks done inside eth_mac_addr() the address was never set. I have not reintroduced the memcpy wrapper, but I've put a comment for future cats. The code now is back to exactly as it was before [f25c80a4]. With the cleanup applied. If the spin_lock is indeed needed then a contender should supply a test case that fails, then fix it with the proper locking, as a separate unrelated patch. CC: Julia Lawall <julia@diku.dk> CC: David S. Miller <davem@davemloft.net> CC: Andrew Morton <akpm@linux-foundation.org> CC: Al Viro <viro@ZenIV.linux.org.uk> Tested-by: Boaz Harrosh <bharrosh@panasas.com> Signed-off-by: Boaz Harrosh <bharrosh@panasas.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2010-09-29 19:30:11 -07:00
..
chan_kern.c	um: call free_irq() only on enabled channels	2010-08-09 20:45:04 -07:00
chan_user.c
cow_sys.h
cow_user.c
cow.h
daemon_kern.c
daemon_user.c
daemon.h
fd.c
harddog_kern.c	uml: Pushdown the bkl from harddog_kern ioctl	2010-05-22 17:44:21 +02:00
harddog_user.c
hostaudio_kern.c	param: simple locking for sysfs-writable charp parameters	2010-08-11 23:04:31 +09:30
line.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial	2010-05-20 09:20:59 -07:00
Makefile
mcast_kern.c
mcast_user.c
mcast.h
mconsole_kern.c	Input: sysrq - drop tty argument form handle_sysrq()	2010-08-21 00:34:45 -07:00
mconsole_user.c
mmapper_kern.c	um/mmapper: Remove BKL usage	2010-05-17 05:27:03 +02:00
net_kern.c	um: Proper Fix for f25c80a4: remove duplicate structure field initialization	2010-09-29 19:30:11 -07:00
net_user.c
null.c
pcap_kern.c
pcap_user.c
pcap_user.h
port_kern.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	2010-03-30 22:02:32 +09:00
port_user.c
port.h
pty.c
random.c	um: Remove BKL from random	2009-10-14 15:35:51 +02:00
slip_common.c
slip_common.h
slip_kern.c
slip_user.c
slip.h
slirp_kern.c
slirp_user.c
slirp.h
ssl.c
ssl.h
stderr_console.c
stdio_console.c
stdio_console.h
tty.c
ubd_kern.c	block: push down BKL into .open and .release	2010-08-07 18:25:34 +02:00
ubd_user.c
vde_kern.c
vde_user.c
vde.h
xterm_kern.c
xterm.c
xterm.h