1
linux/drivers/usb/core
Linus Torvalds ddeee0b2ee USB: usbfs: properly clean up the as structure on error paths
I notice that the processcompl_compat() function seems to be leaking the
'struct async *as' in the error paths. 

I think that the calling convention is fundamentally buggered. The
caller is the one that did the "reap_as()" to get the as thing, the
caller should be the one to free it too. 

Freeing it in the caller also means that it very clearly always gets
freed, and avoids the need for any "free in the error case too".

From: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Marcus Meissner <meissner@suse.de>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-02-16 15:11:02 -08:00
..
buffer.c
config.c
devices.c USB: Don't use GFP_KERNEL while we cannot reset a storage device 2010-01-20 15:24:34 -08:00
devio.c USB: usbfs: properly clean up the as structure on error paths 2010-02-16 15:11:02 -08:00
driver.c USB: add remove_id sysfs attr for usb drivers 2009-12-11 11:55:26 -08:00
endpoint.c
file.c USB: fix possible null deref in init_usb_class() 2009-12-11 11:55:22 -08:00
generic.c USB: Convert a dev_info to a dev_dbg 2009-12-11 11:55:13 -08:00
hcd-pci.c const: constify remaining dev_pm_ops 2009-12-15 08:53:25 -08:00
hcd.c USB: Fix duplicate sysfs problem after device reset. 2010-01-20 15:24:35 -08:00
hcd.h const: constify remaining dev_pm_ops 2009-12-15 08:53:25 -08:00
hub.c USB: Fix duplicate sysfs problem after device reset. 2010-01-20 15:24:35 -08:00
hub.h
inode.c
Kconfig
Makefile
message.c USB: Don't use GFP_KERNEL while we cannot reset a storage device 2010-01-20 15:24:34 -08:00
notify.c
otg_whitelist.h
quirks.c
sysfs.c USB: add speed values for USB 3.0 and wireless controllers 2010-01-20 15:24:35 -08:00
urb.c USB: allow interrupt transfers to WUSB devices 2009-12-11 11:55:14 -08:00
usb.c USB core: fix recent kernel-doc warnings 2009-12-23 11:34:12 -08:00
usb.h USB: add a "remove hardware" sysfs attribute 2009-12-11 11:55:18 -08:00