b9c16a0e1f
In commit:659cf9f582("locking/ww_mutex: Optimize ww-mutexes by waking at most one waiter for backoff when acquiring the lock") I replaced a comment with a lockdep_assert_held(). However it turns out we hide that lock from lockdep for hysterical raisins, which results in the assertion always firing. Remove the old debug code as lockdep will easily spot the abuse it was meant to catch, which will make the lock visible to lockdep and make the assertion work as intended. Reported-by: Mike Galbraith <efault@gmx.de> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Nicolai Haehnle <Nicolai.Haehnle@amd.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Fixes:659cf9f582("locking/ww_mutex: Optimize ww-mutexes by waking at most one waiter for backoff when acquiring the lock") Link: http://lkml.kernel.org/r/20170117150609.GB32474@worktop Signed-off-by: Ingo Molnar <mingo@kernel.org>
25 lines
802 B
C
25 lines
802 B
C
/*
|
|
* Mutexes: blocking mutual exclusion locks
|
|
*
|
|
* started by Ingo Molnar:
|
|
*
|
|
* Copyright (C) 2004, 2005, 2006 Red Hat, Inc., Ingo Molnar <mingo@redhat.com>
|
|
*
|
|
* This file contains mutex debugging related internal prototypes, for the
|
|
* !CONFIG_DEBUG_MUTEXES case. Most of them are NOPs:
|
|
*/
|
|
|
|
#define mutex_remove_waiter(lock, waiter, task) \
|
|
__list_del((waiter)->list.prev, (waiter)->list.next)
|
|
|
|
#define debug_mutex_wake_waiter(lock, waiter) do { } while (0)
|
|
#define debug_mutex_free_waiter(waiter) do { } while (0)
|
|
#define debug_mutex_add_waiter(lock, waiter, ti) do { } while (0)
|
|
#define debug_mutex_unlock(lock) do { } while (0)
|
|
#define debug_mutex_init(lock, name, key) do { } while (0)
|
|
|
|
static inline void
|
|
debug_mutex_lock_common(struct mutex *lock, struct mutex_waiter *waiter)
|
|
{
|
|
}
|