1
linux/drivers/net/wireless/iwlwifi
Sven Wegener 5cbbb376d6 iwlwifi: Don't use buffer allocated on the stack for led names
Having the buffer on the stack and even re-using it for all led devices is bad.
Not being able to resolve the name member of the led device structure to a
meaningful value leads to confusion during ad-hoc debugging and potential
breakage in the future, if we ever decide to access the name member outside of
the registration function. Move the buffer to our private per led device
structures so that it is accessible after registration.

A quick grep didn't yield any occurence of using the led device name parameter
outside of the led device registration function, so currently we should already
be safe for normal operation.

Signed-off-by: Sven Wegener <sven.wegener@stealer.net>
Cc: Richard Purdie <rpurdie@rpsys.net>
Acked-by: Zhu Yi <yi.zhu@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2008-08-04 15:09:11 -04:00
..
iwl3945-base.c iwlwifi: fix checkpatch.pl errors 2008-08-04 15:09:11 -04:00
iwl-3945-commands.h iwlwifi: iwl3945 remove 4965 commands 2008-03-25 16:41:54 -04:00
iwl-3945-core.h
iwl-3945-debug.h
iwl-3945-hw.h iwlwifi: 3945 remove unused SCD definitions 2008-05-07 15:02:20 -04:00
iwl-3945-io.h
iwl-3945-led.c iwlwifi: Don't use buffer allocated on the stack for led names 2008-08-04 15:09:11 -04:00
iwl-3945-led.h iwlwifi: Don't use buffer allocated on the stack for led names 2008-08-04 15:09:11 -04:00
iwl-3945-rs.c mac80211: move TX info into skb->cb 2008-05-21 21:48:11 -04:00
iwl-3945-rs.h iwlwifi: move rate registration to module load 2008-04-01 17:13:19 -04:00
iwl-3945.c iwlwifi: fix checkpatch.pl errors 2008-08-04 15:09:11 -04:00
iwl-3945.h iwlwifi: Fix LEDs for 3945 2008-07-14 14:53:00 -04:00
iwl-4965-hw.h iwlwifi: differentiate 4965 and 5000 hw ampdu queues number 2008-07-14 14:52:59 -04:00
iwl-4965.c iwlwifi: fix checkpatch.pl errors 2008-08-04 15:09:11 -04:00
iwl-5000-hw.h iwlwifi: differentiate 4965 and 5000 hw ampdu queues number 2008-07-14 14:52:59 -04:00
iwl-5000.c iwlwifi: fix checkpatch.pl errors 2008-08-04 15:09:11 -04:00
iwl-agn-rs.c iwlwifi: fix checkpatch.pl errors 2008-08-04 15:09:11 -04:00
iwl-agn-rs.h iwlwifi: kill iwl4965_fill_rs_info 2008-08-04 15:09:08 -04:00
iwl-agn.c iwlwifi: rename 4965 to AGN 2008-08-04 15:09:11 -04:00
iwl-calib.c iwlwifi: move RX stats to core, and move temperature to handler 2008-06-30 17:37:39 -04:00
iwl-calib.h iwlwifi: move RX stats to core, and move temperature to handler 2008-06-30 17:37:39 -04:00
iwl-commands.h iwlwifi: use dtim_period from association, and set listen_interval 2008-08-04 15:09:10 -04:00
iwl-core.c iwlwifi: fix checkpatch.pl errors 2008-08-04 15:09:11 -04:00
iwl-core.h iwlwifi: add power save to 5000 HW 2008-08-04 15:09:06 -04:00
iwl-csr.h iwlwifi: setup correctly L1 L0S pi link values 2008-06-03 15:00:20 -04:00
iwl-debug.h iwlwifi: fix checkpatch.pl errors 2008-08-04 15:09:11 -04:00
iwl-debugfs.c iwlwifi: fix checkpatch.pl errors 2008-08-04 15:09:11 -04:00
iwl-dev.h iwlwifi: rename 4965 to AGN 2008-08-04 15:09:11 -04:00
iwl-eeprom.c iwlwifi: fix checkpatch.pl errors 2008-08-04 15:09:11 -04:00
iwl-eeprom.h iwlwifi-5000: implement initial calibration for 5000 2008-06-03 15:00:23 -04:00
iwl-fh.h iwlwifi: move Flow Handlers define to iwl-fh.h 2008-05-07 15:02:20 -04:00
iwl-hcmd.c iwlwifi: add REPLY_TX_POWER_DBM_CMD to get_cmd_string 2008-06-30 17:37:39 -04:00
iwl-helpers.h mac80211: add helpers for frame control testing 2008-06-14 12:18:12 -04:00
iwl-io.h iwlwifi: improve NIC i/o debug prints information 2008-03-27 16:03:17 -04:00
iwl-led.c iwlwifi: Don't use buffer allocated on the stack for led names 2008-08-04 15:09:11 -04:00
iwl-led.h iwlwifi: Don't use buffer allocated on the stack for led names 2008-08-04 15:09:11 -04:00
iwl-power.c iwlwifi: corrects power_level in sysfs 2008-08-04 15:09:06 -04:00
iwl-power.h iwlwifi: corrects power_level in sysfs 2008-08-04 15:09:06 -04:00
iwl-prph.h iwlwifi: move aggregation code to iwl-tx.c 2008-06-03 15:00:25 -04:00
iwl-rfkill.c iwlwifi: remove input device and fix rfkill state 2008-07-08 10:21:35 -04:00
iwl-rfkill.h iwlwifi: remove input device and fix rfkill state 2008-07-08 10:21:35 -04:00
iwl-rx.c iwlwif: remove compilation warnings iwl_add_radiotap 2008-07-14 14:52:57 -04:00
iwl-scan.c iwlwifi: small compile warnings without CONFIG_IWLWIFI_DEBUG 2008-07-29 16:55:03 -04:00
iwl-spectrum.h
iwl-sta.c iwlwifi: fix checkpatch.pl errors 2008-08-04 15:09:11 -04:00
iwl-sta.h iwlwifi: better station table maintenance 2008-06-30 17:37:38 -04:00
iwl-tx.c iwlwifi: bug fix in AGG flow - cast const to ULL 2008-08-04 15:09:09 -04:00
Kconfig iwlwifi: rename 4965 to AGN 2008-08-04 15:09:11 -04:00
Makefile iwlwifi: rename 4965 to AGN 2008-08-04 15:09:11 -04:00