1
linux/fs/nfsd
Bruce Allan f35279d3f7 [PATCH] sunrpc: cache_register can use wrong module reference
When registering an RPC cache, cache_register() always sets the owner as the
sunrpc module.  However, there are RPC caches owned by other modules.  With
the incorrect owner setting, the real owning module can be removed potentially
with an open reference to the cache from userspace.

For example, if one were to stop the nfs server and unmount the nfsd
filesystem, the nfsd module could be removed eventhough rpc.idmapd had
references to the idtoname and nametoid caches (i.e.
/proc/net/rpc/nfs4.<cachename>/channel is still open).  This resulted in a
system panic on one of our machines when attempting to restart the nfs
services after reloading the nfsd module.

The following patch adds a 'struct module *owner' field in struct
cache_detail.  The owner is further assigned to the struct proc_dir_entry
in cache_register() so that the module cannot be unloaded while user-space
daemons have an open reference on the associated file under /proc.

Signed-off-by: Bruce Allan <bwa@us.ibm.com>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Neil Brown <neilb@cse.unsw.edu.au>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2005-09-07 16:57:25 -07:00
..
auth.c
export.c [PATCH] sunrpc: cache_register can use wrong module reference 2005-09-07 16:57:25 -07:00
lockd.c
Makefile [PATCH] knfsd: nfsd4: reboot hash 2005-06-24 00:06:33 -07:00
nfs2acl.c [PATCH] NFSD: Add server support for NFSv3 ACLs. 2005-06-22 16:07:23 -04:00
nfs3acl.c [PATCH] NFSD: Add server support for NFSv3 ACLs. 2005-06-22 16:07:23 -04:00
nfs3proc.c
nfs3xdr.c [PATCH] NFSD: Add server support for NFSv3 ACLs. 2005-06-22 16:07:23 -04:00
nfs4acl.c [PATCH] knfsd: nfsd4: make needlessly global code static 2005-06-24 00:06:33 -07:00
nfs4callback.c [PATCH] knfsd: nfsd4: remove cb_parsed 2005-06-24 00:06:35 -07:00
nfs4idmap.c [PATCH] sunrpc: cache_register can use wrong module reference 2005-09-07 16:57:25 -07:00
nfs4proc.c [PATCH] nfsd4: ERR_GRACE should bump seqid on open 2005-07-07 18:24:08 -07:00
nfs4recover.c [CRYPTO]: crypto_free_tfm() callers no longer need to check for NULL 2005-09-01 17:44:29 -07:00
nfs4state.c [PATCH] nfsd4: check lock type against openmode. 2005-07-07 18:24:11 -07:00
nfs4xdr.c [PATCH] nfsd4: fix fh_expire_type 2005-07-07 18:24:11 -07:00
nfscache.c
nfsctl.c [PATCH] knfsd: nfsd4 reboot dirname fix 2005-06-24 00:06:36 -07:00
nfsfh.c
nfsproc.c
nfssvc.c [PATCH] nfsd to unlock kernel before exiting 2005-08-17 12:53:05 -07:00
nfsxdr.c [PATCH] NFSD: Add server support for NFSv3 ACLs. 2005-06-22 16:07:23 -04:00
stats.c
vfs.c [PATCH] inotify 2005-07-12 20:38:38 -07:00