kevin/linux
1
Fork 0
Code
55db4c64ed
linux/drivers/net/can
History
Linus Torvalds 55db4c64ed Revert "tty: make receive_buf() return the amout of bytes received" 
This reverts commit b1c43f82c5.

It was broken in so many ways, and results in random odd pty issues.

It re-introduced the buggy schedule_work() in flush_to_ldisc() that can
cause endless work-loops (see commit a5660b41af: "tty: fix endless
work loop when the buffer fills up").

It also used an "unsigned int" return value fo the ->receive_buf()
function, but then made multiple functions return a negative error code,
and didn't actually check for the error in the caller.

And it didn't actually work at all.  BenH bisected down odd tty behavior
to it:
  "It looks like the patch is causing some major malfunctions of the X
   server for me, possibly related to PTYs.  For example, cat'ing a
   large file in a gnome terminal hangs the kernel for -minutes- in a
   loop of what looks like flush_to_ldisc/workqueue code, (some ftrace
   data in the quoted bits further down).

   ...

   Some more data: It -looks- like what happens is that the
   flush_to_ldisc work queue entry constantly re-queues itself (because
   the PTY is full ?) and the workqueue thread will basically loop
   forver calling it without ever scheduling, thus starving the consumer
   process that could have emptied the PTY."

which is pretty much exactly the problem we fixed in a5660b41af.

Milton Miller pointed out the 'unsigned int' issue.

Reported-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Reported-by: Milton Miller <miltonm@bga.com>
Cc: Stefan Bigler <stefan.bigler@keymile.com>
Cc: Toby Gray <toby.gray@realvnc.com>
Cc: Felipe Balbi <balbi@ti.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2011-06-04 06:33:24 +09:00
..
c_can Fix common misspellings 2011-03-31 11:26:23 -03:00
mscan drivercore: revert addition of of_match to struct device 2011-05-18 12:32:23 -06:00
sja1000 can: fix SJA1000 dlc for RTR packets 2011-05-05 11:02:22 -07:00
softing Merge git://git.kernel.org/pub/scm/linux/kernel/git/brodo/pcmcia-2.6 2011-05-24 13:28:35 -07:00
usb Fix common misspellings 2011-03-31 11:26:23 -03:00
at91_can.c Fix common misspellings 2011-03-31 11:26:23 -03:00
bfin_can.c
dev.c
flexcan.c
janz-ican3.c mfd: Use mfd cell platform_data for janz cells platform bits 2011-05-26 19:45:08 +02:00
Kconfig
Makefile
mcp251x.c can: mcp251x: Allow pass IRQ flags through platform data. 2011-04-06 12:24:26 -07:00
pch_can.c treewide: fix a few typos in comments 2011-05-10 10:16:21 +02:00
slcan.c Revert "tty: make receive_buf() return the amout of bytes received" 2011-06-04 06:33:24 +09:00
ti_hecc.c Fix common misspellings 2011-03-31 11:26:23 -03:00
vcan.c