kevin/linux
1
Fork 0
Code
47c87d930f
linux/drivers/staging/et131x
History
Marcin Slusarz 1af4791552 staging/et131x: fix et131x_rx_dma_disable halt_status usage 
Commit 1bd751c1ab
("Staging: et131x: Clean up rxdma_csr") changed csr from bitfield to
u32, but failed to convert 2 uses of halt_status bit. It did:

- if (csr.bits.halt_status != 1)
+ if ((csr & 0x00020000) != 1)

which is wrong, because second version is always true.
Fix it.

This bug was found by coccinelle (http://coccinelle.lip6.fr/).

Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-02-23 14:39:09 -08:00
..
et131x_adapter.h staging: et131x: Clean up the RFD struct/types 2011-02-04 13:01:01 -08:00
et131x_defs.h
et131x_initpci.c staging: et131x: Clean up the phy coma stuff 2011-02-04 13:01:01 -08:00
et131x_isr.c staging: et131x: Begin cleaning up the MI registers 2011-02-04 13:01:01 -08:00
et131x_netdev.c staging: et131x: Turn a few more LongCapitalisedThings into Linuxish names 2011-02-04 13:01:00 -08:00
et131x_version.h
et131x.h staging: et131x: Clean up the RFD struct/types 2011-02-04 13:01:01 -08:00
et1310_address_map.h
et1310_eeprom.c staging: et131x: Turn a few more LongCapitalisedThings into Linuxish names 2011-02-04 13:01:00 -08:00
et1310_mac.c staging: et131x: Kill of the eFLOW_CONTROL enum 2011-02-04 13:01:00 -08:00
et1310_phy.c staging: et131x: Begin cleaning up the MI registers 2011-02-04 13:01:01 -08:00
et1310_phy.h staging: et131x: Begin cleaning up the MI registers 2011-02-04 13:01:01 -08:00
et1310_pm.c staging: et131x: Clean up the phy coma stuff 2011-02-04 13:01:01 -08:00
et1310_rx.c staging/et131x: fix et131x_rx_dma_disable halt_status usage 2011-02-23 14:39:09 -08:00
et1310_rx.h
et1310_tx.c staging: et131x: Kill of the eFLOW_CONTROL enum 2011-02-04 13:01:00 -08:00
et1310_tx.h
Kconfig
Makefile Staging: et131x: Makefile: replace the use of <module>-objs with <module>-y 2010-10-08 07:23:49 -07:00
README

README 

This is a driver for the ET1310 network device.

Based on the driver found at https://sourceforge.net/projects/et131x/

Cleaned up immensely by Olaf Hartman <o.hartmann@telovital.com> and Christoph
Hellwig <hch@infradead.org>

Note, the powermanagement options were removed from the vendor provided
driver as they did not build properly at the time.

TODO:
	- kernel coding style cleanups
	- forward port for latest network driver changes
	- kill useless typecasts (e.g. in et1310_phy.c)
	- alloc_etherdev is initializing memory with zero?!?
	- add_timer call in et131x_netdev.c is correct?
	- Add power saving functionality (suspend, sleep, resume)
	- Implement a few more kernel Parameter (set mac )

Please send patches to:
	Greg Kroah-Hartman <gregkh@suse.de>

And Cc: Olaf Hartmann <o.hartmann@telovital.com> as he has this device and can
test any changes.