1
linux/drivers/usb
James Woodcock 331879fd6f USB: serial: refuse to open recently removed USB Serial devices
A USB-serial converter device is plugged into a system, and a process
opens it's device node.  If the device is physically removed whilst the
process still has its device node open, then other processes can
sucessfully open the now non-existent device's node.  I would expect
that open() on a device that has been physically removed should return
ENODEV.

This is manifesting itself with getty on my system.  I do the following:
1.  set up inittab to spawn getty on ttyUSB0, eg:
    T1:23:respawn:/sbin/getty -L ttyUSB0 115200 vt100
2.  Plug in USB-serial converter cable
3.  Wait for a login prompt on a terminal program attached to the serial
    cable
4.  Login
5.  Pull the USB-serial converter cable from the box
6.  getty doesn't realise that ttyUSB0 no longer exists as /dev/ttyUSB0
    can still be opened.
7.  Re-insert the USB-serial converter cable
8.  You should no longer get a login prompt over the serial cable, as
    the the USB-serial cable now shows up as /dev/ttyUSB1, and getty is
    trying to talk to /dev/ttyUSB0.

The attached patch will cause open("/dev/ttyUSB0", O_RDONLY) to return
ENODEV after the USB-serial converter has been pulled.  The patch was
created against 2.6.28.1.  I can supply it against something else if
needs be.  It is fairly simple, so should be OK.

I am using a pl2303 device, although I don't think that makes any
difference.


From: James Woodcock <James.Woodcock@ACULAB.COM>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-03-24 16:20:31 -07:00
..
atm USB: atm/cxacru, fix lock imbalance 2009-03-17 14:01:28 -07:00
c67x00
class usblp: continuously poll for status 2009-03-24 16:20:26 -07:00
core USB: drivers: use USB API functions rather than constants 2009-03-24 16:20:28 -07:00
gadget USB: add missing KERN_* constants to printks 2009-03-24 16:20:30 -07:00
host USB: add missing KERN_* constants to printks 2009-03-24 16:20:30 -07:00
image USB: image/mdc800, fix lock imbalance 2009-03-17 14:01:28 -07:00
misc USB: misc/vstusb, fix lock imbalance 2009-03-17 14:01:29 -07:00
mon USB: usbmon: Implement compat_ioctl 2009-01-27 16:15:36 -08:00
musb USB: musb: fix srp sysfs entry deletion 2009-02-27 14:40:51 -08:00
otg USB: otg: adding nop usb transceiver 2009-03-24 16:20:30 -07:00
serial USB: serial: refuse to open recently removed USB Serial devices 2009-03-24 16:20:31 -07:00
storage usb_storage: make Kconfig note visible in the console 2009-03-24 16:20:30 -07:00
wusbcore USB: wusbcore/wa-xfer, fix lock imbalance 2009-03-17 14:01:29 -07:00
Kconfig USB: move isp1301_omap to drivers/usb/otg 2009-01-07 10:00:02 -08:00
Makefile USB: Correct Makefile to make isp1760 buildable 2009-02-09 11:19:49 -08:00
README
usb-skeleton.c USB: skeleton: Use dev_info instead of info 2009-03-24 16:20:30 -07:00

To understand all the Linux-USB framework, you'll use these resources:

    * This source code.  This is necessarily an evolving work, and
      includes kerneldoc that should help you get a current overview.
      ("make pdfdocs", and then look at "usb.pdf" for host side and
      "gadget.pdf" for peripheral side.)  Also, Documentation/usb has
      more information.

    * The USB 2.0 specification (from www.usb.org), with supplements
      such as those for USB OTG and the various device classes.
      The USB specification has a good overview chapter, and USB
      peripherals conform to the widely known "Chapter 9".

    * Chip specifications for USB controllers.  Examples include
      host controllers (on PCs, servers, and more); peripheral
      controllers (in devices with Linux firmware, like printers or
      cell phones); and hard-wired peripherals like Ethernet adapters.

    * Specifications for other protocols implemented by USB peripheral
      functions.  Some are vendor-specific; others are vendor-neutral
      but just standardized outside of the www.usb.org team.

Here is a list of what each subdirectory here is, and what is contained in
them.

core/		- This is for the core USB host code, including the
		  usbfs files and the hub class driver ("khubd").

host/		- This is for USB host controller drivers.  This
		  includes UHCI, OHCI, EHCI, and others that might
		  be used with more specialized "embedded" systems.

gadget/		- This is for USB peripheral controller drivers and
		  the various gadget drivers which talk to them.


Individual USB driver directories.  A new driver should be added to the
first subdirectory in the list below that it fits into.

image/		- This is for still image drivers, like scanners or
		  digital cameras.
../input/	- This is for any driver that uses the input subsystem,
		  like keyboard, mice, touchscreens, tablets, etc.
../media/	- This is for multimedia drivers, like video cameras,
		  radios, and any other drivers that talk to the v4l
		  subsystem.
../net/		- This is for network drivers.
serial/		- This is for USB to serial drivers.
storage/	- This is for USB mass-storage drivers.
class/		- This is for all USB device drivers that do not fit
		  into any of the above categories, and work for a range
		  of USB Class specified devices. 
misc/		- This is for all USB device drivers that do not fit
		  into any of the above categories.