1
linux/drivers/net/tulip
Joe Perches c251c7f738 drivers/net/tulip/eeprom.c: fix bogus "(null)" in tulip init messages
On Wed, 2010-03-10 at 08:41 -0800, David Miller wrote:
> From: Mikael Pettersson <mikpe@it.uu.se>
> Date: Wed, 10 Mar 2010 16:33:28 +0100
> > Booting 2.6.34-rc1 on a machine with a tulip nic I see
> > a number of kernel messages that include "(null)" where
> > previous kernels included the string "tulip0":
> CC:'ing the guilty party :-)  It's one of the following
> commits:

Thanks Mikael.

Anonymity has some good attributes.
Blame avoidance is one of them.

I've broad shoulders.  It's me, then Dwight Howard...

There might be another few of these where ->name or ->dev
was used before struct device or net_device was registered.
I'll go back and check.

tulip_core has:

	if (tp->flags & HAS_MEDIA_TABLE) {
		sprintf(dev->name, DRV_NAME "%d", board_idx);	/* hack */
		tulip_parse_eeprom(dev);
		strcpy(dev->name, "eth%d");			/* un-hack */
	}

So I don't feel _too_ bad.

tulip_parse_eeprom is done before register_netdev so the logging
there can not use netdev_<level> or dev_<level>(&dev->dev

Signed-off-by: Joe Perches <joe@perches.com>
Tested-by: Mikael Pettersson <mikpe@it.uu.se>
Signed-off-by: David S. Miller <davem@davemloft.net>
2010-03-13 12:26:15 -08:00
..
21142.c tulip/21142.c: Use dev_<level> and pr_<level> 2010-01-31 23:26:52 -08:00
de4x5.c tulip: convert to use netdev_for_each_mc_addr 2010-02-18 14:47:50 -08:00
de4x5.h
de2104x.c tulip: convert to use netdev_for_each_mc_addr 2010-02-18 14:47:50 -08:00
dmfe.c tulip: convert to use netdev_for_each_mc_addr 2010-02-18 14:47:50 -08:00
eeprom.c drivers/net/tulip/eeprom.c: fix bogus "(null)" in tulip init messages 2010-03-13 12:26:15 -08:00
interrupt.c tulip/interrupt.c: Use dev_<level> and pr_<level> 2010-01-31 23:26:54 -08:00
Kconfig dmfe/tulip: Let dmfe handle DM910x except for SPARC on-board chips 2010-01-07 17:27:31 -08:00
Makefile
media.c tulip/media.c: Use dev_<level> and pr_<level> 2010-01-31 23:26:55 -08:00
pnic2.c tulip/pnic2.c: Use dev_<level> and pr_<level> 2010-01-31 23:26:56 -08:00
pnic.c tulip/pnic.c: Use dev_<level> and pr_<level> 2010-01-31 23:26:55 -08:00
timer.c tulip/timer.c: Use dev_<level> and pr_<level> 2010-01-31 23:26:56 -08:00
tulip_core.c tulip: convert to use netdev_for_each_mc_addr 2010-02-18 14:47:50 -08:00
tulip.h
uli526x.c tulip: convert to use netdev_for_each_mc_addr 2010-02-18 14:47:50 -08:00
winbond-840.c tulip: convert to use netdev_for_each_mc_addr 2010-02-18 14:47:50 -08:00
xircom_cb.c tulip/xircom_cb.c: Use dev_<level> and pr_<level> 2010-01-31 23:26:58 -08:00