1
linux/arch/ia64
Hugh Dickins 2fd4ef85e0 [PATCH] error path in setup_arg_pages() misses vm_unacct_memory()
Pavel Emelianov and Kirill Korotaev observe that fs and arch users of
security_vm_enough_memory tend to forget to vm_unacct_memory when a
failure occurs further down (typically in setup_arg_pages variants).

These are all users of insert_vm_struct, and that reservation will only
be unaccounted on exit if the vma is marked VM_ACCOUNT: which in some
cases it is (hidden inside VM_STACK_FLAGS) and in some cases it isn't.

So x86_64 32-bit and ppc64 vDSO ELFs have been leaking memory into
Committed_AS each time they're run.  But don't add VM_ACCOUNT to them,
it's inappropriate to reserve against the very unlikely case that gdb
be used to COW a vDSO page - we ought to do something about that in
do_wp_page, but there are yet other inconsistencies to be resolved.

The safe and economical way to fix this is to let insert_vm_struct do
the security_vm_enough_memory check when it finds VM_ACCOUNT is set.

And the MIPS irix_brk has been calling security_vm_enough_memory before
calling do_brk which repeats it, doubly accounting and so also leaking.
Remove that, and all the fs and arch calls to security_vm_enough_memory:
give it a less misleading name later on.

Signed-off-by: Hugh Dickins <hugh@veritas.com>
Signed-Off-By: Kirill Korotaev <dev@sw.ru>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2005-09-14 11:18:13 -07:00
..
configs [IA64] Manual merge fix for 3 files 2005-09-08 14:27:13 -07:00
dig Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
hp Pull sim-fixes into release branch 2005-09-11 14:27:15 -07:00
ia32 [PATCH] error path in setup_arg_pages() misses vm_unacct_memory() 2005-09-14 11:18:13 -07:00
kernel Pull sim-fixes into release branch 2005-09-11 14:27:15 -07:00
lib [IA64] Manual merge fix for 3 files 2005-09-08 14:27:13 -07:00
mm Pull sim-fixes into release branch 2005-09-11 14:27:15 -07:00
oprofile Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
pci [IA64] Minor cleanups - remove CONFIG_ACPI_DEALLOCATE_IRQ 2005-09-07 14:00:08 -07:00
scripts Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
sn Pull sn-features into release branch 2005-09-11 14:34:23 -07:00
defconfig [IA64] Manual merge fix for 3 files 2005-09-08 14:27:13 -07:00
install.sh Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
Kconfig [IA64] Manual merge fix for 3 files 2005-09-08 14:27:13 -07:00
Kconfig.debug [PATCH] Kprobes/IA64: arch specific handling 2005-06-23 09:45:22 -07:00
Makefile kbuild: rename prepare to archprepare to fix dependency chain 2005-09-11 22:30:22 +02:00
module.lds Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00