2c956a6077
SipHash is a 64-bit keyed hash function that is actually a cryptographically secure PRF, like HMAC. Except SipHash is super fast, and is meant to be used as a hashtable keyed lookup function, or as a general PRF for short input use cases, such as sequence numbers or RNG chaining. For the first usage: There are a variety of attacks known as "hashtable poisoning" in which an attacker forms some data such that the hash of that data will be the same, and then preceeds to fill up all entries of a hashbucket. This is a realistic and well-known denial-of-service vector. Currently hashtables use jhash, which is fast but not secure, and some kind of rotating key scheme (or none at all, which isn't good). SipHash is meant as a replacement for jhash in these cases. There are a modicum of places in the kernel that are vulnerable to hashtable poisoning attacks, either via userspace vectors or network vectors, and there's not a reliable mechanism inside the kernel at the moment to fix it. The first step toward fixing these issues is actually getting a secure primitive into the kernel for developers to use. Then we can, bit by bit, port things over to it as deemed appropriate. While SipHash is extremely fast for a cryptographically secure function, it is likely a bit slower than the insecure jhash, and so replacements will be evaluated on a case-by-case basis based on whether or not the difference in speed is negligible and whether or not the current jhash usage poses a real security risk. For the second usage: A few places in the kernel are using MD5 or SHA1 for creating secure sequence numbers, syn cookies, port numbers, or fast random numbers. SipHash is a faster and more fitting, and more secure replacement for MD5 in those situations. Replacing MD5 and SHA1 with SipHash for these uses is obvious and straight-forward, and so is submitted along with this patch series. There shouldn't be much of a debate over its efficacy. Dozens of languages are already using this internally for their hash tables and PRFs. Some of the BSDs already use this in their kernels. SipHash is a widely known high-speed solution to a widely known set of problems, and it's time we catch-up. Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> Reviewed-by: Jean-Philippe Aumasson <jeanphilippe.aumasson@gmail.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Eric Biggers <ebiggers3@gmail.com> Cc: David Laight <David.Laight@aculab.com> Cc: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
132 lines
4.4 KiB
C
132 lines
4.4 KiB
C
/* Test cases for siphash.c
|
|
*
|
|
* Copyright (C) 2016 Jason A. Donenfeld <Jason@zx2c4.com>. All Rights Reserved.
|
|
*
|
|
* This file is provided under a dual BSD/GPLv2 license.
|
|
*
|
|
* SipHash: a fast short-input PRF
|
|
* https://131002.net/siphash/
|
|
*
|
|
* This implementation is specifically for SipHash2-4.
|
|
*/
|
|
|
|
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
|
|
|
|
#include <linux/siphash.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/string.h>
|
|
#include <linux/errno.h>
|
|
#include <linux/module.h>
|
|
|
|
/* Test vectors taken from official reference source available at:
|
|
* https://131002.net/siphash/siphash24.c
|
|
*/
|
|
|
|
static const siphash_key_t test_key_siphash =
|
|
{{ 0x0706050403020100ULL, 0x0f0e0d0c0b0a0908ULL }};
|
|
|
|
static const u64 test_vectors_siphash[64] = {
|
|
0x726fdb47dd0e0e31ULL, 0x74f839c593dc67fdULL, 0x0d6c8009d9a94f5aULL,
|
|
0x85676696d7fb7e2dULL, 0xcf2794e0277187b7ULL, 0x18765564cd99a68dULL,
|
|
0xcbc9466e58fee3ceULL, 0xab0200f58b01d137ULL, 0x93f5f5799a932462ULL,
|
|
0x9e0082df0ba9e4b0ULL, 0x7a5dbbc594ddb9f3ULL, 0xf4b32f46226bada7ULL,
|
|
0x751e8fbc860ee5fbULL, 0x14ea5627c0843d90ULL, 0xf723ca908e7af2eeULL,
|
|
0xa129ca6149be45e5ULL, 0x3f2acc7f57c29bdbULL, 0x699ae9f52cbe4794ULL,
|
|
0x4bc1b3f0968dd39cULL, 0xbb6dc91da77961bdULL, 0xbed65cf21aa2ee98ULL,
|
|
0xd0f2cbb02e3b67c7ULL, 0x93536795e3a33e88ULL, 0xa80c038ccd5ccec8ULL,
|
|
0xb8ad50c6f649af94ULL, 0xbce192de8a85b8eaULL, 0x17d835b85bbb15f3ULL,
|
|
0x2f2e6163076bcfadULL, 0xde4daaaca71dc9a5ULL, 0xa6a2506687956571ULL,
|
|
0xad87a3535c49ef28ULL, 0x32d892fad841c342ULL, 0x7127512f72f27cceULL,
|
|
0xa7f32346f95978e3ULL, 0x12e0b01abb051238ULL, 0x15e034d40fa197aeULL,
|
|
0x314dffbe0815a3b4ULL, 0x027990f029623981ULL, 0xcadcd4e59ef40c4dULL,
|
|
0x9abfd8766a33735cULL, 0x0e3ea96b5304a7d0ULL, 0xad0c42d6fc585992ULL,
|
|
0x187306c89bc215a9ULL, 0xd4a60abcf3792b95ULL, 0xf935451de4f21df2ULL,
|
|
0xa9538f0419755787ULL, 0xdb9acddff56ca510ULL, 0xd06c98cd5c0975ebULL,
|
|
0xe612a3cb9ecba951ULL, 0xc766e62cfcadaf96ULL, 0xee64435a9752fe72ULL,
|
|
0xa192d576b245165aULL, 0x0a8787bf8ecb74b2ULL, 0x81b3e73d20b49b6fULL,
|
|
0x7fa8220ba3b2eceaULL, 0x245731c13ca42499ULL, 0xb78dbfaf3a8d83bdULL,
|
|
0xea1ad565322a1a0bULL, 0x60e61c23a3795013ULL, 0x6606d7e446282b93ULL,
|
|
0x6ca4ecb15c5f91e1ULL, 0x9f626da15c9625f3ULL, 0xe51b38608ef25f57ULL,
|
|
0x958a324ceb064572ULL
|
|
};
|
|
|
|
static int __init siphash_test_init(void)
|
|
{
|
|
u8 in[64] __aligned(SIPHASH_ALIGNMENT);
|
|
u8 in_unaligned[65] __aligned(SIPHASH_ALIGNMENT);
|
|
u8 i;
|
|
int ret = 0;
|
|
|
|
for (i = 0; i < 64; ++i) {
|
|
in[i] = i;
|
|
in_unaligned[i + 1] = i;
|
|
if (siphash(in, i, &test_key_siphash) !=
|
|
test_vectors_siphash[i]) {
|
|
pr_info("siphash self-test aligned %u: FAIL\n", i + 1);
|
|
ret = -EINVAL;
|
|
}
|
|
if (siphash(in_unaligned + 1, i, &test_key_siphash) !=
|
|
test_vectors_siphash[i]) {
|
|
pr_info("siphash self-test unaligned %u: FAIL\n", i + 1);
|
|
ret = -EINVAL;
|
|
}
|
|
}
|
|
if (siphash_1u64(0x0706050403020100ULL, &test_key_siphash) !=
|
|
test_vectors_siphash[8]) {
|
|
pr_info("siphash self-test 1u64: FAIL\n");
|
|
ret = -EINVAL;
|
|
}
|
|
if (siphash_2u64(0x0706050403020100ULL, 0x0f0e0d0c0b0a0908ULL,
|
|
&test_key_siphash) != test_vectors_siphash[16]) {
|
|
pr_info("siphash self-test 2u64: FAIL\n");
|
|
ret = -EINVAL;
|
|
}
|
|
if (siphash_3u64(0x0706050403020100ULL, 0x0f0e0d0c0b0a0908ULL,
|
|
0x1716151413121110ULL, &test_key_siphash) !=
|
|
test_vectors_siphash[24]) {
|
|
pr_info("siphash self-test 3u64: FAIL\n");
|
|
ret = -EINVAL;
|
|
}
|
|
if (siphash_4u64(0x0706050403020100ULL, 0x0f0e0d0c0b0a0908ULL,
|
|
0x1716151413121110ULL, 0x1f1e1d1c1b1a1918ULL,
|
|
&test_key_siphash) != test_vectors_siphash[32]) {
|
|
pr_info("siphash self-test 4u64: FAIL\n");
|
|
ret = -EINVAL;
|
|
}
|
|
if (siphash_1u32(0x03020100U, &test_key_siphash) !=
|
|
test_vectors_siphash[4]) {
|
|
pr_info("siphash self-test 1u32: FAIL\n");
|
|
ret = -EINVAL;
|
|
}
|
|
if (siphash_2u32(0x03020100U, 0x07060504U, &test_key_siphash) !=
|
|
test_vectors_siphash[8]) {
|
|
pr_info("siphash self-test 2u32: FAIL\n");
|
|
ret = -EINVAL;
|
|
}
|
|
if (siphash_3u32(0x03020100U, 0x07060504U,
|
|
0x0b0a0908U, &test_key_siphash) !=
|
|
test_vectors_siphash[12]) {
|
|
pr_info("siphash self-test 3u32: FAIL\n");
|
|
ret = -EINVAL;
|
|
}
|
|
if (siphash_4u32(0x03020100U, 0x07060504U,
|
|
0x0b0a0908U, 0x0f0e0d0cU, &test_key_siphash) !=
|
|
test_vectors_siphash[16]) {
|
|
pr_info("siphash self-test 4u32: FAIL\n");
|
|
ret = -EINVAL;
|
|
}
|
|
if (!ret)
|
|
pr_info("self-tests: pass\n");
|
|
return ret;
|
|
}
|
|
|
|
static void __exit siphash_test_exit(void)
|
|
{
|
|
}
|
|
|
|
module_init(siphash_test_init);
|
|
module_exit(siphash_test_exit);
|
|
|
|
MODULE_AUTHOR("Jason A. Donenfeld <Jason@zx2c4.com>");
|
|
MODULE_LICENSE("Dual BSD/GPL");
|