1
linux/arch
Steven Rostedt (Google) 2c92ca849f tracing/treewide: Remove second parameter of __assign_str()
With the rework of how the __string() handles dynamic strings where it
saves off the source string in field in the helper structure[1], the
assignment of that value to the trace event field is stored in the helper
value and does not need to be passed in again.

This means that with:

  __string(field, mystring)

Which use to be assigned with __assign_str(field, mystring), no longer
needs the second parameter and it is unused. With this, __assign_str()
will now only get a single parameter.

There's over 700 users of __assign_str() and because coccinelle does not
handle the TRACE_EVENT() macro I ended up using the following sed script:

  git grep -l __assign_str | while read a ; do
      sed -e 's/\(__assign_str([^,]*[^ ,]\) *,[^;]*/\1)/' $a > /tmp/test-file;
      mv /tmp/test-file $a;
  done

I then searched for __assign_str() that did not end with ';' as those
were multi line assignments that the sed script above would fail to catch.

Note, the same updates will need to be done for:

  __assign_str_len()
  __assign_rel_str()
  __assign_rel_str_len()

I tested this with both an allmodconfig and an allyesconfig (build only for both).

[1] https://lore.kernel.org/linux-trace-kernel/20240222211442.634192653@goodmis.org/

Link: https://lore.kernel.org/linux-trace-kernel/20240516133454.681ba6a0@rorschach.local.home

Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Acked-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Christian König <christian.koenig@amd.com> for the amdgpu parts.
Acked-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> #for
Acked-by: Rafael J. Wysocki <rafael@kernel.org> # for thermal
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Darrick J. Wong <djwong@kernel.org>	# xfs
Tested-by: Guenter Roeck <linux@roeck-us.net>
2024-05-22 20:14:47 -04:00
..
alpha The usual shower of singleton fixes and minor series all over MM, 2024-05-19 09:21:03 -07:00
arc asm-generic cleanups for 6.10 2024-05-20 15:18:34 -07:00
arm USB / Thunderbolt changes for 6.10-rc1 2024-05-22 11:40:09 -07:00
arm64 tracing/treewide: Remove second parameter of __assign_str() 2024-05-22 20:14:47 -04:00
csky The usual shower of singleton fixes and minor series all over MM, 2024-05-19 09:21:03 -07:00
hexagon
loongarch LoongArch changes for v6.10 2024-05-22 09:43:07 -07:00
m68k m68knommu: updates and fixes for v6.10 2024-05-21 12:05:40 -07:00
microblaze Microblaze patches for 6.10-rc1 2024-05-22 09:31:01 -07:00
mips - Core Frameworks 2024-05-22 10:49:54 -07:00
nios2 Kbuild updates for v6.10 2024-05-18 12:39:20 -07:00
openrisc
parisc asm-generic cleanups for 6.10 2024-05-20 15:18:34 -07:00
powerpc tracing/treewide: Remove second parameter of __assign_str() 2024-05-22 20:14:47 -04:00
riscv RISC-V Patches for the 6.10 Merge Window, Part 1 2024-05-22 09:56:00 -07:00
s390 more s390 updates for 6.10 merge window 2024-05-21 12:09:36 -07:00
sh asm-generic cleanups for 6.10 2024-05-20 15:18:34 -07:00
sparc asm-generic cleanups for 6.10 2024-05-20 15:18:34 -07:00
um asm-generic cleanups for 6.10 2024-05-20 15:18:34 -07:00
x86 tracing/treewide: Remove second parameter of __assign_str() 2024-05-22 20:14:47 -04:00
xtensa The usual shower of singleton fixes and minor series all over MM, 2024-05-19 09:21:03 -07:00
.gitignore
Kconfig kprobes: remove dependency on CONFIG_MODULES 2024-05-14 00:35:06 -07:00