kevin/linux
1
Fork 0
Code
281981ca87
linux/drivers/watchdog
History
Linus Torvalds cd92a17eec iTCO_wdt: fix typo when setting TCO_EN bit 
The code used '&= 0x00002000' when it tried to set the TCO_EN bit, which
obviously didn't set that bit at all, but instead just reset all the
other bits in the SMI_EN register.

This bug seemingly caused various random behavior, with Frans Pop
reporting that X.org just silently hung at startup and Rafael Wysocki
reports the fan spinning with full speed.

See
	http://lkml.org/lkml/2008/12/3/178
	http://bugzilla.kernel.org/show_bug.cgi?id=12162

The problem seems to have been triggered by "[WATCHDOG] iTCO_wdt :
problem with rebooting on new ICH9 based motherboards" (commit
7cd5b08be3), but the bogus code existed
before that too (in the "supermicro_old_pre_stop()" function), it just
apparently never showed up due to different logic.

In that commit the broken code got moved around and now gets executed
much more.

Reported-by: Rafael J. Wysocki <rjw@sisk.pl>
Tested-by: Frans Pop <elendil@planet.nl>
Cc: Wim Van Sebroeck <wim@iguana.be>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-12-03 16:20:19 -08:00
..
acquirewdt.c [PATCH] Switch all my contributions stuff to a single common address 2008-10-28 19:16:11 +00:00
advantechwdt.c [PATCH] Switch all my contributions stuff to a single common address 2008-10-28 19:16:11 +00:00
alim1535_wdt.c
alim7101_wdt.c
ar7_wdt.c
at32ap700x_wdt.c
at91rm9200_wdt.c
at91sam9_wdt.c [WATCHDOG] SAM9 watchdog - update for moved headers 2008-11-06 08:44:11 +00:00
bfin_wdt.c [PATCH] Switch all my contributions stuff to a single common address 2008-10-28 19:16:11 +00:00
booke_wdt.c powerpc: Fix Book-E watchdog timer interval setting 2008-11-08 12:38:59 -06:00
cpu5wdt.c
cpwd.c
davinci_wdt.c
ep93xx_wdt.c
eurotechwdt.c [PATCH] Switch all my contributions stuff to a single common address 2008-10-28 19:16:11 +00:00
geodewdt.c [WATCHDOG] unlocked_ioctl changes 2008-09-23 08:12:30 +00:00
hpwdt.c [WATCHDOG] hpwdt: Fix kdump when using hpwdt 2008-12-01 15:55:10 +00:00
i6300esb.c [WATCHDOG] pci: use pci_ioremap_bar() in drivers/watchdog 2008-10-24 07:47:24 +00:00
ib700wdt.c [PATCH] Switch all my contributions stuff to a single common address 2008-10-28 19:16:11 +00:00
ibmasr.c
indydog.c [PATCH] Switch all my contributions stuff to a single common address 2008-10-28 19:16:11 +00:00
iop_wdt.c
it87_wdt.c [WATCHDOG] add watchdog driver IT8716 IT8726 IT8712J/K 2008-10-10 13:09:17 +00:00
it8712f_wdt.c
iTCO_vendor_support.c [WATCHDOG] iTCO_wdt : problem with rebooting on new ICH9 based motherboards 2008-11-21 08:34:26 +00:00
iTCO_vendor.h
iTCO_wdt.c iTCO_wdt: fix typo when setting TCO_EN bit 2008-12-03 16:20:19 -08:00
ixp4xx_wdt.c
ixp2000_wdt.c
Kconfig [WATCHDOG] SAM9 watchdog - supported on all SAM9 and CAP9 processors 2008-11-06 08:54:37 +00:00
ks8695_wdt.c
machzwd.c
Makefile Merge git://git.kernel.org/pub/scm/linux/kernel/git/wim/linux-2.6-watchdog 2008-10-12 11:51:32 -07:00
mixcomwd.c
mpc8xxx_wdt.c
mpc5200_wdt.c
mpcore_wdt.c [PATCH] Switch all my contributions stuff to a single common address 2008-10-28 19:16:11 +00:00
mtx-1_wdt.c [WATCHDOG] fix mtx1_wdt compilation failure 2008-11-21 08:20:49 +00:00
mv64x60_wdt.c
omap_wdt.c [PATCH] Switch all my contributions stuff to a single common address 2008-10-28 19:16:11 +00:00
omap_wdt.h [WATCHDOG] omap_wdt.c: sync linux-omap changes 2008-10-10 13:11:10 +00:00
orion5x_wdt.c [WATCHDOG] orion5x_wdt.c: add spinlocking 2008-10-10 13:17:43 +00:00
pc87413_wdt.c
pcwd_pci.c [PATCH] Switch all my contributions stuff to a single common address 2008-10-28 19:16:11 +00:00
pcwd_usb.c [PATCH] Switch all my contributions stuff to a single common address 2008-10-28 19:16:11 +00:00
pcwd.c
pnx4008_wdt.c [WATCHDOG] unlocked_ioctl changes 2008-09-23 08:12:30 +00:00
rc32434_wdt.c [PATCH] Switch all my contributions stuff to a single common address 2008-10-28 19:16:11 +00:00
rdc321x_wdt.c [WATCHDOG] unlocked_ioctl changes 2008-09-23 08:12:30 +00:00
riowd.c
rm9k_wdt.c
s3c2410_wdt.c [PATCH] Switch all my contributions stuff to a single common address 2008-10-28 19:16:11 +00:00
sa1100_wdt.c [PATCH] Switch all my contributions stuff to a single common address 2008-10-28 19:16:11 +00:00
sb_wdog.c [PATCH] Switch all my contributions stuff to a single common address 2008-10-28 19:16:11 +00:00
sbc60xxwdt.c
sbc7240_wdt.c
sbc8360.c [PATCH] Switch all my contributions stuff to a single common address 2008-10-28 19:16:11 +00:00
sbc_epx_c3.c [PATCH] Switch all my contributions stuff to a single common address 2008-10-28 19:16:11 +00:00
sc520_wdt.c
sc1200wdt.c
scx200_wdt.c
shwdt.c
smsc37b787_wdt.c [PATCH] Switch all my contributions stuff to a single common address 2008-10-28 19:16:11 +00:00
softdog.c [PATCH] Switch all my contributions stuff to a single common address 2008-10-28 19:16:11 +00:00
txx9wdt.c
w83627hf_wdt.c [PATCH] Switch all my contributions stuff to a single common address 2008-10-28 19:16:11 +00:00
w83697hf_wdt.c [PATCH] Switch all my contributions stuff to a single common address 2008-10-28 19:16:11 +00:00
w83697ug_wdt.c watchdog: Fix warning 2008-10-23 09:19:47 -07:00
w83877f_wdt.c
w83977f_wdt.c
wafer5823wdt.c [PATCH] Switch all my contributions stuff to a single common address 2008-10-28 19:16:11 +00:00
wd501p.h
wdrtas.c
wdt285.c [PATCH] Switch all my contributions stuff to a single common address 2008-10-28 19:16:11 +00:00
wdt977.c
wdt_pci.c [PATCH] Switch all my contributions stuff to a single common address 2008-10-28 19:16:11 +00:00
wdt.c [PATCH] Switch all my contributions stuff to a single common address 2008-10-28 19:16:11 +00:00