kevin/linux
1
Fork 0
Code
202ff1c26c
linux/drivers/net/ethernet
History
Hiroaki SHIMODA 202ff1c26c tg3: Fix advertisement handling 
Commit 28011cf19b (net: Add ethtool to mii advertisment conversion
helpers) added a helper function ethtool_adv_to_mii_100bt() and
tg3_copper_is_advertising_all(), tg3_phy_autoneg_cfg() were
modified to use this.
Before that commit, ethtool to mii advertisement conversion was
done wrt speed, but now pause operation is also taken account.
So, in tg3_copper_is_advertising_all(), below condition becomes
true and this makes link up fails.

	if ((adv_reg & ADVERTISE_ALL) != all_mask)
		return 0;

To fix this add ADVERTISE_ALL bit and operation to cap speed,
and change default advertisement not including ADVERTISED_Pause.

Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2011-11-22 15:19:07 -05:00
..
3com sweep the floors and convert some .get_drvinfo routines to strlcpy 2011-11-08 15:11:57 -05:00
8390 ethernet: Convert ETHER_ADDR_LEN uses to ETH_ALEN 2011-11-16 20:23:17 -05:00
adaptec sweep the floors and convert some .get_drvinfo routines to strlcpy 2011-11-08 15:11:57 -05:00
adi
aeroflex
alteon
amd amd8111e: Convert ETH_ADDR_LEN uses to ETH_ALEN 2011-11-16 20:23:18 -05:00
apple
atheros net: introduce and use netdev_features_t for device features sets 2011-11-16 17:43:10 -05:00
broadcom tg3: Fix advertisement handling 2011-11-22 15:19:07 -05:00
brocade bna: Convert MAC_ADDRLEN uses to ETH_ALEN 2011-11-16 20:23:18 -05:00
cadence net/cadence: enable by default NET_ATMEL 2011-11-16 17:33:50 -05:00
chelsio net: introduce and use netdev_features_t for device features sets 2011-11-16 17:43:10 -05:00
cirrus
cisco Sweep the last of the active .get_drvinfo floors under ethernet/ 2011-11-14 14:13:31 -05:00
davicom net: introduce and use netdev_features_t for device features sets 2011-11-16 17:43:10 -05:00
dec sweep the floors and convert some .get_drvinfo routines to strlcpy 2011-11-08 15:11:57 -05:00
dlink sweep the floors and convert some .get_drvinfo routines to strlcpy 2011-11-08 15:11:57 -05:00
emulex be2net: Use V1 query link status command for lancer 2011-11-16 18:07:10 -05:00
faraday
freescale gianfar: Use kmemdup rather than duplicating its implementation 2011-11-21 15:02:36 -05:00
fujitsu net: sweep-up some straglers in strlcpy conversion of .get_drvinfo routines 2011-11-16 17:38:55 -05:00
hp
i825xx sweep the floors and convert some .get_drvinfo routines to strlcpy 2011-11-08 15:11:57 -05:00
ibm ibm/emac: fix improper cleanup when device is removed to allow re-bind 2011-11-17 17:04:57 -05:00
icplus
intel Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next 2011-11-16 18:31:56 -05:00
marvell Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net 2011-11-21 13:50:33 -05:00
mellanox Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net 2011-11-21 13:50:33 -05:00
micrel ksz884x: Use kzalloc rather than kmalloc followed by memset with 0 2011-11-21 15:02:36 -05:00
microchip
myricom net: introduce and use netdev_features_t for device features sets 2011-11-16 17:43:10 -05:00
natsemi sweep the floors and convert some .get_drvinfo routines to strlcpy 2011-11-08 15:11:57 -05:00
neterion net: introduce and use netdev_features_t for device features sets 2011-11-16 17:43:10 -05:00
nuvoton
nvidia Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net 2011-11-21 13:50:33 -05:00
octeon
oki-semi Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net 2011-11-21 13:50:33 -05:00
packetengines
pasemi
qlogic net: introduce and use netdev_features_t for device features sets 2011-11-16 17:43:10 -05:00
racal
rdc r6040: fix check against MCRO_HASHEN bit in r6040_multicast_list 2011-11-16 20:24:52 -05:00
realtek ethernet: Convert MAC_ADDR_LEN uses to ETH_ALEN 2011-11-16 20:23:17 -05:00
renesas
seeq
sfc net: introduce and use netdev_features_t for device features sets 2011-11-16 17:43:10 -05:00
sgi
silan
sis ethernet: Convert MAC_ADDR_LEN uses to ETH_ALEN 2011-11-16 20:23:17 -05:00
smsc Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net 2011-11-21 13:50:33 -05:00
stmicro Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net 2011-11-21 13:50:33 -05:00
sun net: Change mii to ethtool advertisement function names 2011-11-21 15:27:19 -05:00
tehuti
ti
tile
toshiba
tundra
via Sweep additional floors of strcpy in .get_drvinfo routines 2011-11-14 00:35:46 -05:00
xilinx Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net 2011-11-21 13:50:33 -05:00
xircom sweep the floors and convert some .get_drvinfo routines to strlcpy 2011-11-08 15:11:57 -05:00
xscale
dnet.c sweep the floors and convert some .get_drvinfo routines to strlcpy 2011-11-08 15:11:57 -05:00
dnet.h
ethoc.c
fealnx.c sweep the floors and convert some .get_drvinfo routines to strlcpy 2011-11-08 15:11:57 -05:00
jme.c net: drivers: use bool type instead of double negation 2011-11-16 23:12:20 -05:00
jme.h
Kconfig
korina.c
lantiq_etop.c NET: MIPS: lantiq: fix etop compile error 2011-11-14 14:34:54 -05:00
Makefile
mipsnet.c
netx-eth.c
s6gmac.c