1
linux/drivers/regulator
Philipp Zabel c8f1e5025c regulator/max1586: fix V3 gain calculation integer overflow
On Thu, May 28, 2009 at 10:59 AM, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> On Thu, May 28, 2009 at 07:15:16AM +0200, Philipp Zabel wrote:
>> The V3 regulator can be configured with an external resistor
>> connected to the feedback pin (R24 in the data sheet) to
>> increase the voltage range.
>>
>> For example, hx4700 has R24 = 3.32 kOhm to achieve a maximum
>> V3 voltage of 1.55 V which is needed for 624 MHz CPU frequency.
>>
>> Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
>
> Looks good.
>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

Thanks, but it turns out I hit a 32 bit integer overflow in
the gain calculation. I'd like to mend that with the following
patch. Now max_uV could be increased up to 4.294 V, enough to
charge LiPo cells.

Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
2009-06-15 11:18:27 +01:00
..
bq24022.c
core.c
da903x.c regulator: Move regulator drivers to subsys_initcall() 2009-06-15 11:18:23 +01:00
fixed.c regulator: Set MODULE_ALIAS for regulator drivers 2009-06-15 11:18:24 +01:00
Kconfig LP3971 PMIC regulator driver (updated and combined version) 2009-06-15 11:18:26 +01:00
lp3971.c regulator: lp3971 - fix driver link error when built-in. 2009-06-15 11:18:26 +01:00
Makefile LP3971 PMIC regulator driver (updated and combined version) 2009-06-15 11:18:26 +01:00
max1586.c regulator/max1586: fix V3 gain calculation integer overflow 2009-06-15 11:18:27 +01:00
pcf50633-regulator.c regulator: Move regulator drivers to subsys_initcall() 2009-06-15 11:18:23 +01:00
twl4030-regulator.c
userspace-consumer.c regulator: build fix for powerpc - renamed show_state 2009-06-15 11:18:23 +01:00
virtual.c regulator: Set MODULE_ALIAS for regulator drivers 2009-06-15 11:18:24 +01:00
wm8350-regulator.c regulator: Set MODULE_ALIAS for regulator drivers 2009-06-15 11:18:24 +01:00
wm8400-regulator.c regulator: remove driver_data direct access of struct device 2009-06-15 11:18:25 +01:00