1
linux/drivers/net/ethernet
Xander Hover 15ac2b08a2 b44: Use dev_kfree_skb_irq() in b44_tx()
Reported issues when using dev_kfree_skb() on UP systems and
systems with low numbers of cores.  dev_kfree_skb_irq() will
properly save IRQ state before freeing the skb.

Tested on 3.1.1 and 3.2_rc2

Example of reproducible trace of kernel 3.1.1
------------[ cut here ]------------
   WARNING: at kernel/softirq.c:159 local_bh_enable+0x32/0x79()
   ...
   Pid: 0, comm: swapper Not tainted 3.1.1-gentoo #1
   Call Trace:
    [<c1022970>] warn_slowpath_common+0x65/0x7a
    [<c102699e>] ? local_bh_enable+0x32/0x79
    [<c1022994>] warn_slowpath_null+0xf/0x13
    [<c102699e>] local_bh_enable+0x32/0x79
    [<c134bfd8>] destroy_conntrack+0x7c/0x9b
    [<c134890b>] nf_conntrack_destroy+0x1f/0x26
    [<c132e3a6>] skb_release_head_state+0x74/0x83
    [<c132e286>] __kfree_skb+0xb/0x6b
    [<c132e30a>] consume_skb+0x24/0x26
    [<c127c925>] b44_poll+0xaa/0x449
    [<c1333ca1>] net_rx_action+0x3f/0xea
    [<c1026a44>] __do_softirq+0x5f/0xd5
    [<c10269e5>] ? local_bh_enable+0x79/0x79
    <IRQ>  [<c1026c32>] ? irq_exit+0x34/0x8d
    [<c1003628>] ? do_IRQ+0x74/0x87
    [<c13f5329>] ? common_interrupt+0x29/0x30
    [<c1006e18>] ? default_idle+0x29/0x3e
    [<c10015a7>] ? cpu_idle+0x2f/0x5d
    [<c13e91c5>] ? rest_init+0x79/0x7b
    [<c15c66a9>] ? start_kernel+0x297/0x29c
    [<c15c60b0>] ? i386_start_kernel+0xb0/0xb7
   ---[ end trace 583f33bb1aa207a9 ]---

Signed-off-by: Xander Hover <LKML@hover.be>
Signed-off-by: David S. Miller <davem@davemloft.net>
2011-11-23 16:40:31 -05:00
..
3com
8390
adaptec
adi
aeroflex
alteon
amd
apple
atheros
broadcom b44: Use dev_kfree_skb_irq() in b44_tx() 2011-11-23 16:40:31 -05:00
brocade
cadence net/cadence: enable by default NET_ATMEL 2011-11-16 17:33:50 -05:00
chelsio
cirrus
cisco
davicom
dec
dlink
emulex
faraday
freescale Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net 2011-11-07 10:55:33 -08:00
fujitsu
hp
i825xx
ibm iseries_veth: Fix wrong parameter given to sizeof call 2011-11-21 14:56:35 -05:00
icplus
intel Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net 2011-11-07 10:55:33 -08:00
marvell sky2: fix hang in napi_disable 2011-11-17 21:43:57 -05:00
mellanox mlx4_en: Remove FCS bytes from packet length. 2011-11-14 14:25:36 -05:00
micrel
microchip
myricom
natsemi
neterion
nuvoton
nvidia forcedeth: fix stats on hardware without extended stats support 2011-11-14 00:14:39 -05:00
octeon
oki-semi pch_gbe: Move #include of module.h 2011-11-16 17:38:03 -05:00
packetengines
pasemi
qlogic
racal
rdc r6040: fix check against MCRO_HASHEN bit in r6040_multicast_list 2011-11-16 20:24:52 -05:00
realtek r8169: increase the delay parameter of pm_schedule_suspend 2011-11-08 12:37:06 -05:00
renesas
seeq
sfc
sgi
silan
sis
smsc net/smsc911x: Always wait for the chip to be ready 2011-11-14 00:40:50 -05:00
stmicro stmmac: mask mmc interrupts 2011-11-21 15:31:15 -05:00
sun sunhme: Allow usage on SBI based SBus systems 2011-11-08 14:01:42 -05:00
tehuti
ti
tile
toshiba
tundra
via
xilinx net/ll_temac: FIX : Wait for indirect wait to end 2011-11-09 15:39:57 -05:00
xircom
xscale
dnet.c
dnet.h
ethoc.c
fealnx.c
jme.c
jme.h
Kconfig
korina.c
lantiq_etop.c NET: MIPS: lantiq: fix etop compile error 2011-11-14 14:34:54 -05:00
Makefile
mipsnet.c
netx-eth.c
s6gmac.c