kevin/linux
1
Fork 0
Code
1440e0967d
linux/drivers/usb/serial
History
Oliver Neukum e58679805d USB: fix NULL pointer dereference on drivers/usb/serial/whiteheat.c 
Am Sonntag, 16. Dezember 2007 05:23:47 schrieb Andrew Morton:
> On Sat, 15 Dec 2007 07:08:52 -0800 (PST) bugme-daemon@bugzilla.kernel.org wrote:
> 
> > http://bugzilla.kernel.org/show_bug.cgi?id=9573
 
> > There's a null pointer dereference on drivers/usb/serial/whiteheat.c as
> > follows:
> > 
> > (1) line 613:  the test "if (port->tty)" implies that null is a legal value
> >     for "port->tty" at that point
> > 
> > (2) neither firm_open nor firm_purge initialize "port->tty"

drivers/usb/serial/usb-serial::serial_open() sets port->tty
The check for NULL is bogus. This patch removes the check.

Signed-off-by: Oliver Neukum <oneukum@suse.de>
Acked-by: Alan Cox <alan@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2008-02-01 14:34:58 -08:00
..
aircable.c USB: serial: aircable: clean up urb->status usage 2007-07-12 16:34:31 -07:00
airprime.c USB: fix support for Dell Wireless Broadband (aka WWAN) 2007-08-22 14:27:44 -07:00
ark3116.c USB: ark3116: update termios handling 2007-10-25 12:18:40 -07:00
belkin_sa.c USB: belkin_sa: clean up for new style termios and speed handling, plus style 2008-02-01 14:34:56 -08:00
belkin_sa.h
bus.c usb-serial: show port number in sysfs 2007-10-12 14:55:20 -07:00
ch341.c USB: ch341: fix termios handling 2007-10-25 12:18:40 -07:00
ChangeLog.history Convert files to UTF-8 and some cleanups 2007-10-19 23:21:04 +02:00
console.c USB: usb_serial_console: allocate fake tty and termios before calling driver open() method 2008-02-01 14:34:50 -08:00
cp2101.c USB: CP2101 New Device IDs 2008-02-01 14:34:43 -08:00
cyberjack.c USB: cyberjack: remove a unnecessary variable. 2008-02-01 14:34:51 -08:00
cypress_m8.c USB: serial: cypress_m8: clean up urb->status usage 2007-07-12 16:34:32 -07:00
cypress_m8.h
digi_acceleport.c USB: digi_acceleport: fix termios and also readability a bit 2007-10-25 12:18:41 -07:00
empeg.c USB: empeg: clean up and handle speeds 2007-10-25 12:18:41 -07:00
ezusb_convert.pl
ezusb.c
ftdi_sio.c USB: ftdi driver - add support for optical probe device 2008-02-01 14:34:45 -08:00
ftdi_sio.h USB: ftdi driver - add support for optical probe device 2008-02-01 14:34:45 -08:00
funsoft.c USB: funsoft: Fix termios 2007-10-12 14:55:32 -07:00
garmin_gps.c USB: serial: garmin_gps: fixes package loss if used from gpsbabel 2007-08-22 14:27:44 -07:00
generic.c USB: Prepare serial core for autosuspend. 2008-02-01 14:34:51 -08:00
hp4x.c
io_16654.h
io_edgeport.c USB: Spelling fixes 2008-02-01 14:34:57 -08:00
io_edgeport.h
io_fw_boot2.h
io_fw_boot.h
io_fw_down2.h
io_fw_down3.h USB: io_ti: Digi EdgePort update for new devices 2007-07-12 16:29:48 -07:00
io_fw_down.h
io_ionsp.h
io_tables.h
io_ti.c USB: Edgeport USB Serial Converter: convert es_sem to mutex 2008-02-01 14:34:53 -08:00
io_ti.h
io_usbvend.h USB: io_ti: Digi EdgePort update for new devices 2007-07-12 16:29:48 -07:00
ipaq.c Convert files to UTF-8 and some cleanups 2007-10-19 23:21:04 +02:00
ipaq.h
ipw.c Add missing newlines to some uses of dev_<level> messages 2007-10-18 14:37:28 -07:00
ir-usb.c USB: ir_usb: termios handling 2007-10-25 12:18:41 -07:00
iuu_phoenix.c USB: add iuu_phoenix driver 2008-02-01 14:34:47 -08:00
iuu_phoenix.h USB: add iuu_phoenix driver 2008-02-01 14:34:47 -08:00
Kconfig USB: add iuu_phoenix driver 2008-02-01 14:34:47 -08:00
keyspan_mpr_fw.h
keyspan_pda_fw.h
keyspan_pda.c USB: keyspan_pda: clean up speed handling 2008-02-01 14:34:56 -08:00
keyspan_pda.S
keyspan_usa18x_fw.h
keyspan_usa19_fw.h
keyspan_usa19qi_fw.h
keyspan_usa19qw_fw.h
keyspan_usa19w_fw.h
keyspan_usa26msg.h
keyspan_usa28_fw.h
keyspan_usa28msg.h
keyspan_usa28x_fw.h
keyspan_usa28xa_fw.h
keyspan_usa28xb_fw.h
keyspan_usa49msg.h
keyspan_usa49w_fw.h
keyspan_usa49wlc_fw.h
keyspan_usa67msg.h USB Serial Keyspan: add support for USA-49WG & USA-28XG 2007-07-12 16:29:45 -07:00
keyspan_usa90msg.h
keyspan.c USB: keyspan: Fix oops 2008-02-01 14:34:42 -08:00
keyspan.h USB Serial Keyspan: add support for USA-49WG & USA-28XG 2007-07-12 16:29:45 -07:00
kl5kusb105.c USB: kl5kusb105: witch to new speed API 2007-10-12 14:55:15 -07:00
kl5kusb105.h
kobil_sct.c USB: kobil_sct: termios encoding fixups 2007-10-25 12:18:41 -07:00
kobil_sct.h
Makefile USB: add iuu_phoenix driver 2008-02-01 14:34:47 -08:00
Makefile-keyspan_pda_fw
mct_u232.c USB: mct232: speed, new termios and compliance cleanups 2008-02-01 14:34:56 -08:00
mct_u232.h USB: mct232: speed, new termios and compliance cleanups 2008-02-01 14:34:56 -08:00
mos7720.c Add missing newlines to some uses of dev_<level> messages 2007-10-18 14:37:28 -07:00
mos7840.c USB: Spelling fixes 2008-02-01 14:34:57 -08:00
navman.c USB: serial: navman: clean up urb->status usage 2007-07-12 16:34:35 -07:00
omninet.c USB: serial: omninet: clean up urb->status usage 2007-07-12 16:34:35 -07:00
option.c USB: Variant of the Dell Wireless 5520 driver 2008-02-01 14:34:46 -08:00
oti6858.c Add missing newlines to some uses of dev_<level> messages 2007-10-18 14:37:28 -07:00
oti6858.h USB: oti6858 usb-serial driver (in Nokia CA-42 cable) 2007-07-12 16:29:47 -07:00
pl2303.c USB: pl2303: Add autosuspend support to pl2303 usb serial converter. 2008-02-01 14:34:56 -08:00
pl2303.h USB: pl2303: add support for RATOC REX-USB60F 2008-02-01 14:34:45 -08:00
safe_serial.c USB: Remove dead references to "SAFE_SERIAL" CONFIG variables. 2007-10-12 14:54:59 -07:00
sierra.c USB: sierra: add support for Onda H600/Zte MF330 datacard to USB Driver for Sierra Wireless 2008-02-01 14:34:45 -08:00
ti_fw_3410.h
ti_fw_5052.h
ti_usb_3410_5052.c USB: TI 3410/5052 USB Serial: convert td_open_close_lock to mutex 2008-02-01 14:34:48 -08:00
ti_usb_3410_5052.h
usb_debug.c
usb-serial.c USB: Prepare serial core for autosuspend. 2008-02-01 14:34:51 -08:00
visor.c USB: visor: termios bits 2007-10-12 14:55:32 -07:00
visor.h USB: visor add ACER S10 palm device id 2007-08-22 14:27:43 -07:00
whiteheat_fw.h
whiteheat.c USB: fix NULL pointer dereference on drivers/usb/serial/whiteheat.c 2008-02-01 14:34:58 -08:00
whiteheat.h
xircom_pgs_fw.h
xircom_pgs.S