1
linux/kernel/irq
Thomas Gleixner 0fb7fb7134 genirq/msi, platform-msi: Ensure that MSI descriptors are unreferenced
Miquel reported a warning in the MSI core which is triggered when
interrupts are freed via platform_msi_device_domain_free().

This code got reworked to use core functions for freeing the MSI
descriptors, but nothing took care to clear the msi_desc->irq entry, which
then triggers the warning in msi_free_msi_desc() which uses desc->irq to
validate that the descriptor has been torn down. The same issue exists in
msi_domain_populate_irqs().

Up to the point that msi_free_msi_descs() grew a warning for this case,
this went un-noticed.

Provide the counterpart of msi_domain_populate_irqs() and invoke it in
platform_msi_device_domain_free() before freeing the interrupts and MSI
descriptors and also in the error path of msi_domain_populate_irqs().

Fixes: 2f2940d168 ("genirq/msi: Remove filter from msi_free_descs_free_range()")
Reported-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/87mt4wkwnv.ffs@tglx
2023-03-02 18:09:44 +01:00
..
affinity.c genirq/affinity: Move group_cpus_evenly() into lib/ 2023-01-17 18:50:06 +01:00
autoprobe.c
chip.c genirq/irqdomain: Rename irq_domain::dev to irq_domain:: Pm_dev 2022-12-05 19:20:58 +01:00
cpuhotplug.c
debug.h
debugfs.c
devres.c
dummychip.c
generic-chip.c
handle.c
internals.h
ipi-mux.c genirq/ipi-mux: Use irq_domain_alloc_irqs() 2023-02-06 17:21:15 +00:00
ipi.c genirq/ipi: Fix NULL pointer deref in irq_data_get_affinity_mask() 2023-02-20 13:53:41 +01:00
irq_sim.c
irqdesc.c genirq/irqdesc: Make kobj_type structures constant 2023-02-21 15:00:09 +01:00
irqdomain.c irqdomain: Add missing NULL pointer check in irq_domain_create_hierarchy() 2023-02-23 15:52:28 +01:00
Kconfig genirq: Add mechanism to multiplex a single HW IPI 2023-02-05 10:57:55 +00:00
Makefile genirq: Add mechanism to multiplex a single HW IPI 2023-02-05 10:57:55 +00:00
manage.c genirq: Add might_sleep() to disable_irq() 2023-01-11 19:35:13 +01:00
matrix.c
migration.c
msi.c genirq/msi, platform-msi: Ensure that MSI descriptors are unreferenced 2023-03-02 18:09:44 +01:00
pm.c
proc.c
resend.c
settings.h
spurious.c
timings.c