1
linux/arch/ia64/kvm
Julia Lawall cab7a1eeeb KVM: ia64: Fix irq disabling leak in error handling code
There is a call to local_irq_restore in the normal exit case, so it would
seem that there should be one on an error return as well.

The semantic patch that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
expression l;
expression E,E1,E2;
@@

local_irq_save(l);
... when != local_irq_restore(l)
    when != spin_unlock_irqrestore(E,l)
    when any
    when strict
(
if (...) { ... when != local_irq_restore(l)
               when != spin_unlock_irqrestore(E1,l)
+   local_irq_restore(l);
    return ...;
}
|
if (...)
+   {local_irq_restore(l);
    return ...;
+   }
|
spin_unlock_irqrestore(E2,l);
|
local_irq_restore(l);
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Avi Kivity <avi@qumranet.com>
2008-07-27 11:35:32 +03:00
..
asm-offsets.c KVM: ia64: Generate offset values for assembly code use 2008-04-27 12:01:10 +03:00
Kconfig KVM: ia64: Stub out kvmtrace 2008-04-27 12:01:21 +03:00
kvm_fw.c fix build error of arch/ia64/kvm/* 2008-07-17 09:16:31 -07:00
kvm_minstate.h
kvm-ia64.c KVM: ia64: Fix irq disabling leak in error handling code 2008-07-27 11:35:32 +03:00
lapic.h
Makefile KVM: Add coalesced MMIO support (ia64 part) 2008-07-20 12:42:31 +03:00
memcpy.S KVM: ia64: fix GVMM module including position-dependent objects 2008-05-18 14:34:16 +03:00
memset.S KVM: ia64: fix GVMM module including position-dependent objects 2008-05-18 14:34:16 +03:00
misc.h
mmio.c KVM: ia64: fix zero extending for mmio ld1/2/4 emulation in KVM 2008-06-06 21:08:25 +03:00
optvfault.S KVM: ia64: Add optimization for some virtulization faults 2008-04-27 12:01:09 +03:00
process.c KVM: ia64: Add guest interruption injection support 2008-04-27 12:01:11 +03:00
trampoline.S KVM: ia64: Add trampoline for guest/host mode switch 2008-04-27 12:01:08 +03:00
vcpu.c KVM: ia64: Add processor virtulization support 2008-04-27 12:01:09 +03:00
vcpu.h
vmm_ivt.S KVM: ia64: Add interruption vector table for vmm 2008-04-27 12:01:06 +03:00
vmm.c KVM: ia64: VMM module interfaces 2008-04-27 12:01:04 +03:00
vti.h
vtlb.c KVM: ia64: Add TLB virtulization support 2008-04-27 12:01:05 +03:00