bf0db8c759
In some situations 'perf script -F +brstackinsn' sees a lot of "not
reaching sample" messages.
This happens when the last LBR block before the sample contains a branch
that is not in the LBR, and the instruction dumping stops.
$ perf record -b emacs -Q --batch '()'
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.396 MB perf.data (443 samples) ]
$ perf script -F +brstackinsn
...
00007f0ab2d171a4 insn: 41 0f 94 c0
00007f0ab2d171a8 insn: 83 fa 01
00007f0ab2d171ab insn: 74 d3 # PRED 6 cycles [313] 1.00 IPC
00007f0ab2d17180 insn: 45 84 c0
00007f0ab2d17183 insn: 74 28
... not reaching sample ...
$ perf script -F +brstackinsn | grep -c reach
136
$
This is a problem for further analysis that wants to see the full code
upto the sample.
There are two common cases where the message is bogus:
- The LBR only logs taken branches, but the branch might be a
conditional branch that is not taken (that is the most common case
actually)
- The LBR sampling uses a filter ignoring some branches, but the perf
script check checks for all branches.
This patch fixes these two conditions, by only checking for conditional
branches, as well as checking the perf_event_attr's branch filter
attributes.
For the test case above it fixes all the messages:
$ ./perf script -F +brstackinsn | grep -c reach
0
Note that there are still conditions when the message is hit --
sometimes there can be a unconditional branch that misses the LBR update
before the sample -- but they are much more rare now.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
Link: https://lore.kernel.org/r/20240229161828.386397-1-ak@linux.intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
27 lines
535 B
C
27 lines
535 B
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef __PERF_DUMP_INSN_H
|
|
#define __PERF_DUMP_INSN_H 1
|
|
|
|
#define MAXINSN 15
|
|
|
|
#include <linux/types.h>
|
|
|
|
struct thread;
|
|
|
|
struct perf_insn {
|
|
/* Initialized by callers: */
|
|
struct thread *thread;
|
|
struct machine *machine;
|
|
u8 cpumode;
|
|
bool is64bit;
|
|
int cpu;
|
|
/* Temporary */
|
|
char out[256];
|
|
};
|
|
|
|
const char *dump_insn(struct perf_insn *x, u64 ip,
|
|
u8 *inbuf, int inlen, int *lenp);
|
|
int arch_is_uncond_branch(const unsigned char *buf, size_t len, int x86_64);
|
|
|
|
#endif
|