2c9db7475e
Since the "ins.name" is not set while using raw instruction,
'perf annotate' with insn-stat gives wrong data:
Result from "./perf annotate --data-type --insn-stat":
Annotate Instruction stats
total 615, ok 419 (68.1%), bad 196 (31.9%)
Name : Good Bad
-----------------------------------------------------------
: 419 196
This patch sets "dl->ins.name" in arch specific function
"check_ppc_insn" while initialising "struct disasm_line".
Also update "ins_find" function to pass "struct disasm_line" as a
parameter so as to set its name field in arch specific call.
With the patch changes:
Annotate Instruction stats
total 609, ok 446 (73.2%), bad 163 (26.8%)
Name/opcode : Good Bad
-----------------------------------------------------------
58 : 323 80
32 : 49 43
34 : 33 11
OP_31_XOP_LDX : 8 20
40 : 23 0
OP_31_XOP_LWARX : 5 1
OP_31_XOP_LWZX : 2 3
OP_31_XOP_LDARX : 3 0
33 : 0 2
OP_31_XOP_LBZX : 0 1
OP_31_XOP_LWAX : 0 1
OP_31_XOP_LHZX : 0 1
Reviewed-by: Kajol Jain <kjain@linux.ibm.com>
Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Tested-by: Kajol Jain <kjain@linux.ibm.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Akanksha J N <akanksha@linux.ibm.com>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Disha Goel <disgoel@linux.vnet.ibm.com>
Cc: Hari Bathini <hbathini@linux.ibm.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Madhavan Srinivasan <maddy@linux.ibm.com>
Cc: Segher Boessenkool <segher@kernel.crashing.org>
Link: https://lore.kernel.org/lkml/20240718084358.72242-16-atrajeev@linux.vnet.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
128 lines
3.0 KiB
C
128 lines
3.0 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
#ifndef __PERF_UTIL_DISASM_H
|
|
#define __PERF_UTIL_DISASM_H
|
|
|
|
#include "map_symbol.h"
|
|
|
|
#ifdef HAVE_DWARF_SUPPORT
|
|
#include "dwarf-aux.h"
|
|
#endif
|
|
|
|
struct annotation_options;
|
|
struct disasm_line;
|
|
struct ins;
|
|
struct evsel;
|
|
struct symbol;
|
|
struct data_loc_info;
|
|
struct type_state;
|
|
struct disasm_line;
|
|
|
|
struct arch {
|
|
const char *name;
|
|
struct ins *instructions;
|
|
size_t nr_instructions;
|
|
size_t nr_instructions_allocated;
|
|
struct ins_ops *(*associate_instruction_ops)(struct arch *arch, const char *name);
|
|
bool sorted_instructions;
|
|
bool initialized;
|
|
const char *insn_suffix;
|
|
void *priv;
|
|
unsigned int model;
|
|
unsigned int family;
|
|
int (*init)(struct arch *arch, char *cpuid);
|
|
bool (*ins_is_fused)(struct arch *arch, const char *ins1,
|
|
const char *ins2);
|
|
struct {
|
|
char comment_char;
|
|
char skip_functions_char;
|
|
char register_char;
|
|
char memory_ref_char;
|
|
char imm_char;
|
|
} objdump;
|
|
#ifdef HAVE_DWARF_SUPPORT
|
|
void (*update_insn_state)(struct type_state *state,
|
|
struct data_loc_info *dloc, Dwarf_Die *cu_die,
|
|
struct disasm_line *dl);
|
|
#endif
|
|
};
|
|
|
|
struct ins {
|
|
const char *name;
|
|
struct ins_ops *ops;
|
|
};
|
|
|
|
struct ins_operands {
|
|
char *raw;
|
|
struct {
|
|
char *raw;
|
|
char *name;
|
|
struct symbol *sym;
|
|
u64 addr;
|
|
s64 offset;
|
|
bool offset_avail;
|
|
bool outside;
|
|
bool multi_regs;
|
|
bool mem_ref;
|
|
} target;
|
|
union {
|
|
struct {
|
|
char *raw;
|
|
char *name;
|
|
u64 addr;
|
|
bool multi_regs;
|
|
bool mem_ref;
|
|
} source;
|
|
struct {
|
|
struct ins ins;
|
|
struct ins_operands *ops;
|
|
} locked;
|
|
struct {
|
|
char *raw_comment;
|
|
char *raw_func_start;
|
|
} jump;
|
|
};
|
|
};
|
|
|
|
struct ins_ops {
|
|
void (*free)(struct ins_operands *ops);
|
|
int (*parse)(struct arch *arch, struct ins_operands *ops, struct map_symbol *ms,
|
|
struct disasm_line *dl);
|
|
int (*scnprintf)(struct ins *ins, char *bf, size_t size,
|
|
struct ins_operands *ops, int max_ins_name);
|
|
};
|
|
|
|
struct annotate_args {
|
|
struct arch *arch;
|
|
struct map_symbol ms;
|
|
struct evsel *evsel;
|
|
struct annotation_options *options;
|
|
s64 offset;
|
|
char *line;
|
|
int line_nr;
|
|
char *fileloc;
|
|
};
|
|
|
|
struct arch *arch__find(const char *name);
|
|
bool arch__is(struct arch *arch, const char *name);
|
|
|
|
struct ins_ops *ins__find(struct arch *arch, const char *name, struct disasm_line *dl);
|
|
int ins__scnprintf(struct ins *ins, char *bf, size_t size,
|
|
struct ins_operands *ops, int max_ins_name);
|
|
|
|
bool ins__is_call(const struct ins *ins);
|
|
bool ins__is_jump(const struct ins *ins);
|
|
bool ins__is_fused(struct arch *arch, const char *ins1, const char *ins2);
|
|
bool ins__is_nop(const struct ins *ins);
|
|
bool ins__is_ret(const struct ins *ins);
|
|
bool ins__is_lock(const struct ins *ins);
|
|
|
|
struct disasm_line *disasm_line__new(struct annotate_args *args);
|
|
void disasm_line__free(struct disasm_line *dl);
|
|
|
|
int disasm_line__scnprintf(struct disasm_line *dl, char *bf, size_t size,
|
|
bool raw, int max_ins_name);
|
|
|
|
int symbol__disassemble(struct symbol *sym, struct annotate_args *args);
|
|
|
|
#endif /* __PERF_UTIL_DISASM_H */
|