a5384c4267
As there are duplicated kernel headers in tools/include libc can pick
up the wrong definitions. This was causing the wrong system call for
capget in perf.
Reported-by: Adrian Hunter <adrian.hunter@intel.com>
Fixes: e25ebda78e ("perf cap: Tidy up and improve capability testing")
Closes: https://lore.kernel.org/lkml/cc7d6bdf-1aeb-4179-9029-4baf50b59342@intel.com/
Signed-off-by: Ian Rogers <irogers@google.com>
Tested-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20241026055448.312247-1-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
51 lines
1.3 KiB
C
51 lines
1.3 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Capability utilities
|
|
*/
|
|
|
|
#include "cap.h"
|
|
#include "debug.h"
|
|
#include <errno.h>
|
|
#include <string.h>
|
|
#include <linux/capability.h>
|
|
#include <sys/syscall.h>
|
|
#include <unistd.h>
|
|
|
|
#define MAX_LINUX_CAPABILITY_U32S _LINUX_CAPABILITY_U32S_3
|
|
|
|
bool perf_cap__capable(int cap, bool *used_root)
|
|
{
|
|
struct __user_cap_header_struct header = {
|
|
.version = _LINUX_CAPABILITY_VERSION_3,
|
|
.pid = 0,
|
|
};
|
|
struct __user_cap_data_struct data[MAX_LINUX_CAPABILITY_U32S] = {};
|
|
__u32 cap_val;
|
|
|
|
*used_root = false;
|
|
while (syscall(SYS_capget, &header, &data[0]) == -1) {
|
|
/* Retry, first attempt has set the header.version correctly. */
|
|
if (errno == EINVAL && header.version != _LINUX_CAPABILITY_VERSION_3 &&
|
|
header.version == _LINUX_CAPABILITY_VERSION_1)
|
|
continue;
|
|
|
|
pr_debug2("capget syscall failed (%s - %d) fall back on root check\n",
|
|
strerror(errno), errno);
|
|
*used_root = true;
|
|
return geteuid() == 0;
|
|
}
|
|
|
|
/* Extract the relevant capability bit. */
|
|
if (cap >= 32) {
|
|
if (header.version == _LINUX_CAPABILITY_VERSION_3) {
|
|
cap_val = data[1].effective;
|
|
} else {
|
|
/* Capability beyond 32 is requested but only 32 are supported. */
|
|
return false;
|
|
}
|
|
} else {
|
|
cap_val = data[0].effective;
|
|
}
|
|
return (cap_val & (1 << (cap & 0x1f))) != 0;
|
|
}
|